On May 22, 2009, at 12:02 PM, Jay Foad wrote:>> It'd be good for someone actually familiar with invoke could comment >> >> on this. Specifically, in the following testcase, the return value of >> >> the invoke is used in the unwind destination, which is not reachable >> >> from the normal destination. Should this be valid? >> > > No. If the invoked function unwinds then it doesn't return a value. > I'm pretty sure that -verify will reject your testcase.Thanks to you and others for answering this. I've added a sentence to LangRef.html making this explicit. Though, opt -verify does not currently reject the testcase I posted. Dan
>> No. If the invoked function unwinds then it doesn't return a value. >> I'm pretty sure that -verify will reject your testcase. > > Thanks to you and others for answering this. I've added a sentence to > LangRef.html making this explicit.I've had a go at documenting a bit more rigorously how phi and invoke instructions affect the SSA form. Patch attached.> Though, opt -verify does not currently reject the testcase I posted.Is it OK to commit my changes to LangRef.html and then raise bugs against -verify if it doesn't do what I said? :-) Thanks, Jay. -------------- next part -------------- A non-text attachment was scrubbed... Name: patch.phiinvoke Type: application/octet-stream Size: 1270 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090603/82d7c923/attachment.obj>
On Wed, Jun 3, 2009 at 2:50 AM, Jay Foad<jay.foad at gmail.com> wrote:>> Though, opt -verify does not currently reject the testcase I posted. > > Is it OK to commit my changes to LangRef.html and then raise bugs > against -verify if it doesn't do what I said? :-)Looks fine. I think -verify got fixed recently to do the right thing here. -Eli