----- Original Message -----
From: Douglas Gregor
To: LLVM Developers Mailing List
Sent: Friday, May 15, 2009 7:24 PM
Subject: Re: [LLVMdev] [Cygwin] bug on SVN
On May 15, 2009, at 11:03 AM, Aaron Gray wrote:
I am getting a bug building Cygwin on latest SVN :-
llvm[1]: Compiling Process.cpp for Debug build
In file included from /home/ang/git/workbench/lib/System/Process.cpp:29:
/home/ang/git/workbench/lib/System/Unix/Process.inc: In function
'unsigned int g
etColumns(int)':
/home/ang/git/workbench/lib/System/Unix/Process.inc:209: error: aggregate
'winsi
ze ws' has incomplete type and cannot be defined
/home/ang/git/workbench/lib/System/Unix/Process.inc:210: error:
'TIOCGWINSZ' was
not declared in this scope
make[1]: *** [/home/ang/build/workbench/lib/System/Debug/Process.o] Error 1
make[1]: Leaving directory `/home/ang/build/workbench/lib/System'
make: *** [all] Error 1
Having IOCTL.H does not seem to be a strict enough test for struct
winsize'es presence.
#ifdef HAVE_SYS_IOCTL_H
// Try to determine the width of the terminal.
struct winsize ws;
if (ioctl(FileID, TIOCGWINSZ, &ws) == 0)
Columns = ws.ws_col;
#endif
I could not see any changes in Process.cpp's SVN that could have caused
this.
Anyone got a clue ?
>It's my change, here:
>http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20090511/077380.html
>Is struct winsize declared anywhere in the Cygwin headers?
Doug,
It is declared in <sys/termios.h>
Aaron
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090515/4bf5a7c6/attachment.html>
> It is declared in <sys/termios.h>... which is included by <termios.h>, which might be a bit more standard? At least, only <termios.h> is listed here: http://www.opengroup.org/onlinepubs/007908775/headix.html Cheers, Jay.
>> It is declared in <sys/termios.h> > > ... which is included by <termios.h>, which might be a bit more > standard? At least, only <termios.h> is listed here: > > http://www.opengroup.org/onlinepubs/007908775/headix.htmlCheers Jay, Cygwin has 'termios.h'. Aaron
On May 15, 2009, at 12:13 PM, Aaron Gray wrote:> > ----- Original Message ----- > From: Douglas Gregor > To: LLVM Developers Mailing List > Sent: Friday, May 15, 2009 7:24 PM > Subject: Re: [LLVMdev] [Cygwin] bug on SVN > > > On May 15, 2009, at 11:03 AM, Aaron Gray wrote: > >> I am getting a bug building Cygwin on latest SVN :- >> >> llvm[1]: Compiling Process.cpp for Debug build >> In file included from /home/ang/git/workbench/lib/System/ >> Process.cpp:29: >> /home/ang/git/workbench/lib/System/Unix/Process.inc: In function >> 'unsigned int g >> etColumns(int)': >> /home/ang/git/workbench/lib/System/Unix/Process.inc:209: error: >> aggregate 'winsi >> ze ws' has incomplete type and cannot be defined >> /home/ang/git/workbench/lib/System/Unix/Process.inc:210: error: >> 'TIOCGWINSZ' was >> not declared in this scope >> make[1]: *** [/home/ang/build/workbench/lib/System/Debug/Process.o] >> Error 1 >> make[1]: Leaving directory `/home/ang/build/workbench/lib/System' >> make: *** [all] Error 1 >> >> Having IOCTL.H does not seem to be a strict enough test for struct >> winsize'es presence. >> >> #ifdef HAVE_SYS_IOCTL_H >> // Try to determine the width of the terminal. >> struct winsize ws; >> if (ioctl(FileID, TIOCGWINSZ, &ws) == 0) >> Columns = ws.ws_col; >> #endif >> >> I could not see any changes in Process.cpp's SVN that could have >> caused this. >> Anyone got a clue ? >> > > >It's my change, here: > > >http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of- > Mon-20090511/077380.html > > >Is struct winsize declared anywhere in the Cygwin headers? > > Doug, > > It is declared in <sys/termios.h> >Okay, we're now checking for <termios.h> in addition to <sys/ioctl.h>. Hopefully, things are working again on Cygwin with r72018 (but I can't test it here). - Doug -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090518/172d6b3a/attachment.html>
Doug,
Thanks, I will be in a position to check it again tomorrow.
Aaron
----- Original Message -----
From: Douglas Gregor
To: LLVM Developers Mailing List
Sent: Monday, May 18, 2009 6:22 PM
Subject: Re: [LLVMdev] [Cygwin] bug on SVN
On May 15, 2009, at 12:13 PM, Aaron Gray wrote:
----- Original Message -----
From: Douglas Gregor
To: LLVM Developers Mailing List
Sent: Friday, May 15, 2009 7:24 PM
Subject: Re: [LLVMdev] [Cygwin] bug on SVN
On May 15, 2009, at 11:03 AM, Aaron Gray wrote:
I am getting a bug building Cygwin on latest SVN :-
llvm[1]: Compiling Process.cpp for Debug build
In file included from /home/ang/git/workbench/lib/System/Process.cpp:29:
/home/ang/git/workbench/lib/System/Unix/Process.inc: In function
'unsigned int g
etColumns(int)':
/home/ang/git/workbench/lib/System/Unix/Process.inc:209: error:
aggregate 'winsi
ze ws' has incomplete type and cannot be defined
/home/ang/git/workbench/lib/System/Unix/Process.inc:210: error:
'TIOCGWINSZ' was
not declared in this scope
make[1]: *** [/home/ang/build/workbench/lib/System/Debug/Process.o]
Error 1
make[1]: Leaving directory `/home/ang/build/workbench/lib/System'
make: *** [all] Error 1
Having IOCTL.H does not seem to be a strict enough test for struct
winsize'es presence.
#ifdef HAVE_SYS_IOCTL_H
// Try to determine the width of the terminal.
struct winsize ws;
if (ioctl(FileID, TIOCGWINSZ, &ws) == 0)
Columns = ws.ws_col;
#endif
I could not see any changes in Process.cpp's SVN that could have
caused this.
Anyone got a clue ?
>It's my change, here:
>http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20090511/077380.html
>Is struct winsize declared anywhere in the Cygwin headers?
Doug,
It is declared in <sys/termios.h>
Okay, we're now checking for <termios.h> in addition to
<sys/ioctl.h>. Hopefully, things are working again on Cygwin with r72018
(but I can't test it here).
- Doug
------------------------------------------------------------------------------
_______________________________________________
LLVM Developers mailing list
LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090518/8fc99c17/attachment.html>
> Okay, we're now checking for <termios.h> in addition to <sys/ioctl.h>. > Hopefully, things are working again on Cygwin with r72018 (but I can't test > it here).It's still building here, but it definitely gets further than it used to. Thanks Doug! Jay.