llvm dev - Apr 2009 - [LLVMdev] Build fails on windows with VC2008

Hello

The current svn revision fails to compile on windows using Visual Studio
2008.
I'm getting:

3>f:\dev\llvm\lib\codegen\asmprinter\dwarfwriter.cpp(1167) : error C4716:
'llvm::DbgScope::getLine' : must return a value
3>f:\dev\llvm\lib\codegen\asmprinter\dwarfwriter.cpp(1168) : error C4716:
'llvm::DbgScope::getColumn' : must return a value
3>f:\dev\llvm\lib\codegen\asmprinter\dwarfwriter.cpp(1169) : error C4716:
'llvm::DbgScope::getFile' : must return a value

Attached you can find a patch which should fix the issue.

Sincerely yours
Marius Wachtler


Index: DwarfWriter.cpp
==================================================================---
DwarfWriter.cpp    (revision 69629)
+++ DwarfWriter.cpp    (working copy)
@@ -1164,9 +1164,9 @@
   void AddVariable(DbgVariable *V) { Variables.push_back(V); }

   virtual bool isInlinedSubroutine() { return false; }
-  virtual unsigned getLine()   { assert ( 0 && "Unexpected
scope!"); }
-  virtual unsigned getColumn() { assert ( 0 && "Unexpected
scope!"); }
-  virtual unsigned getFile()   { assert ( 0 && "Unexpected
scope!"); }
+  virtual unsigned getLine()   { assert ( 0 && "Unexpected
scope!"); return
0; }
+  virtual unsigned getColumn() { assert ( 0 && "Unexpected
scope!"); return
0; }
+  virtual unsigned getFile()   { assert ( 0 && "Unexpected
scope!"); return
0; }
 };
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090421/ff8dd3b2/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_dwarfwriter.patch
Type: application/octet-stream
Size: 782 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090421/ff8dd3b2/attachment.obj>

On Mon, Apr 20, 2009 at 3:16 PM, Marius Wachtler <malloc at inode.at>
wrote:
> Hello
>
> The current svn revision fails to compile on windows using Visual Studio
> 2008.
> I'm getting:
>
> 3>f:\dev\llvm\lib\codegen\asmprinter\dwarfwriter.cpp(1167) : error
C4716:
> 'llvm::DbgScope::getLine' : must return a value
> 3>f:\dev\llvm\lib\codegen\asmprinter\dwarfwriter.cpp(1168) : error
C4716:
> 'llvm::DbgScope::getColumn' : must return a value
> 3>f:\dev\llvm\lib\codegen\asmprinter\dwarfwriter.cpp(1169) : error
C4716:
> 'llvm::DbgScope::getFile' : must return a value
>
> Attached you can find a patch which should fix the issue.

Applied.
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20090420/076525.html
Thanks!
-
Devang