2009/1/1 Chris Lattner <clattner at apple.com>> On Jan 1, 2009, at 1:21 AM, Talin wrote: > > I'm thinking that getting unit tests for the classes in ADT should > > be an early goal. > > Can I suggest the AP[S]Int class? If you look in llvm/test/Integer > you'll see a whole bunch of tests that really want to be unit tests > but that aren't. :(Chris, do you mean *all* the .ll files in that dir should become unittests, or are you talking about some specific files that should be unittests, and others that should stay as llvm-as/llvm-dis tests? I'm assuming a##.* are prime candidates, what about the others? Are the double llvm-as/llvm-dis tests about bitcode printing/parsing or are they really testing some auto-simplification built-in to the APSInt class? -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090105/abe1854f/attachment.html>
On Jan 5, 2009, at 11:37 AM, Misha Brukman wrote:> 2009/1/1 Chris Lattner <clattner at apple.com> > On Jan 1, 2009, at 1:21 AM, Talin wrote: > > I'm thinking that getting unit tests for the classes in ADT should > > be an early goal. > > Can I suggest the AP[S]Int class? If you look in llvm/test/Integer > you'll see a whole bunch of tests that really want to be unit tests > but that aren't. :( > > Chris, do you mean *all* the .ll files in that dir should become > unittests, or are you talking about some specific files that should > be unittests, and others that should stay as llvm-as/llvm-dis tests? > > I'm assuming a##.* are prime candidates, what about the others? Are > the double llvm-as/llvm-dis tests about bitcode printing/parsing or > are they really testing some auto-simplification built-in to the > APSInt class?Oh, sorry, I just meant the "a*" tests, which are basically doing constant folding (but not checking the results!) -Chris -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090105/4a9ec14a/attachment.html>
On Mon, Jan 5, 2009 at 6:30 PM, Chris Lattner <clattner at apple.com> wrote:> On Jan 5, 2009, at 11:37 AM, Misha Brukman wrote: > > 2009/1/1 Chris Lattner <clattner at apple.com> > >> On Jan 1, 2009, at 1:21 AM, Talin wrote: >> > I'm thinking that getting unit tests for the classes in ADT should >> > be an early goal. >> >> Can I suggest the AP[S]Int class? If you look in llvm/test/Integer >> you'll see a whole bunch of tests that really want to be unit tests >> but that aren't. :( > > > Chris, do you mean *all* the .ll files in that dir should become unittests, > or are you talking about some specific files that should be unittests, and > others that should stay as llvm-as/llvm-dis tests? > > I'm assuming a##.* are prime candidates, what about the others? Are the > double llvm-as/llvm-dis tests about bitcode printing/parsing or are they > really testing some auto-simplification built-in to the APSInt class? > > Oh, sorry, I just meant the "a*" tests, which are basically doing constant > folding (but not checking the results!) >Here's a patch with conversion of a1.ll to unittest format, let me know if this is what you had in mind. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090319/76bff96d/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: APSIntTest_a1.patch Type: text/x-diff Size: 3872 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090319/76bff96d/attachment.patch>