On Tue, Jan 20, 2009 at 8:44 AM, Rafael Espindola <espindola at google.com> wrote:> 2009/1/20 John Regehr <regehr at cs.utah.edu>: >> I'm away from my Linux machines, if this hasn't been resolved by tonight >> I'll send more details. >> >> THe problem in cplus-dem.c is that CPP is conditionally including code that >> comes when HAVE_STDLIB is not defined, including an alternate protptype for >> malloc() that conflicts with the existing one. This is just what causes the >> error I sent-- no idea what the root cause is. > > I have posted a patch that fixes it for me. Waiting for someone to > test it on Darwin. >I do have a concern that this might have regressed the Fortran FE. Could you (or someone who runs it) test this? -bw
> I do have a concern that this might have regressed the Fortran FE. > Could you (or someone who runs it) test this?I noticed my patch was applied and then reverted. I am curious, why was it a problem for the Fortran FE?> -bwCheers, -- Rafael Avila de Espindola Google | Gordon House | Barrow Street | Dublin 4 | Ireland Registered in Dublin, Ireland | Registration Number: 368047
On Wed, Jan 21, 2009 at 1:55 AM, Rafael Espindola <espindola at google.com> wrote:>> I do have a concern that this might have regressed the Fortran FE. >> Could you (or someone who runs it) test this? > > I noticed my patch was applied and then reverted. I am curious, why > was it a problem for the Fortran FE? >Reverted, but with a better fix. :-) I wanted to keep it more in sync with Apple's GCC. The Fortran FE has had a lot of troubles with these warnings. Your patch reverted things back to how they were before the merge, i.e. to the way that would cause the warnings to occur. I don't know why, because the warning mechanism of GCC is opaque to me. -bw