llvm dev - Jan 2008 - [LLVMdev] Adding ClamAV to the llvm testsuite (long)

Evan Cheng wrote:
> Hi,
>   
Hi Evan,
> We are getting closer.
>   
That is good news.
> 1. In Makefile, all the references to CFLAGS should be CPPFLAGS instead.
>   
Done, and  attached.
> 2. filterdiff.sh uses sed -re. This causes a problem on Mac OS X where  
> -E means using extended regular expression, not -r.
> Can this be changed?
>   
I'm not really familiar with sed's non-extended regular expression
syntax, I'll have to read its info page.
I can do that if you decide to keep filterdiff.sh, see below

Evan Cheng wrote:
> On Jan 10, 2008, at 11:28 AM, Evan Cheng wrote:
>
>   
> Looks like the filter might not work correctly for all platforms (at  
> least that appears to be the case on Mac OS X). Can we simply disable  
> those debug outputs?
>
> Thanks,
>   
If it is causing problems, yes.   Or maybe just enable it for certain OSes?
(where sed supports -re?)
How would you prefer?
> 3. This triggers a optimizer bug:
> [...]
>
> I'll file a bug on this.
>   
Ok, that bug didn't trigger for me,  is it x86/ppc specific? (I use x86-64).

--Edwin
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: Makefile
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20080110/bb6de972/attachment.ksh>

Török Edwin wrote:
> Done, and  attached.
>   
Attached the wrong file, sorry. Here is the correct one.

--Edwin
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: Makefile
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20080110/59229cba/attachment.ksh>

>> 2. filterdiff.sh uses sed -re. This causes a problem on Mac OS X  
>> where
>> -E means using extended regular expression, not -r.
>> Can this be changed?
>>
>
> I'm not really familiar with sed's non-extended regular expression
> syntax, I'll have to read its info page.
> I can do that if you decide to keep filterdiff.sh, see below
Why not just hack the program to not print out those file names?

-Chris

Chris Lattner wrote:
> Why not just hack the program to not print out those file names?
>   
Thanks for the tip., I just hacked cli_dbgmsg to do a simple puts of its
format argument.
That should still make the output useful for the testsuite (ensure that
llvm compiled code takes same codepath as gcc compiled code),
and also avoid problems with filterdiff.sh.

Updated tarball is here, let me know what you think:

http://edwintorok.googlepages.com/ClamAV-srcflat3.tar.gz
md5sum:
22bb9be67418ea75da078080e0d396fc  ClamAV-srcflat3.tar.gz


Best regards,
Edwin