I just made a patch to our local llvm build here to pass -D_GLIBCXX_DEBUG when
building llvm. This switch turns on debug code in libstdc++ that checks for
various violations. We've already discovered several llvm bugs with it.
Should I commit a change back to the official sources? It will almost
certainly cause tests to fail, but that's a GOOD thing.
-Dave
On Thu, 7 Jun 2007, David A. Greene wrote:> I just made a patch to our local llvm build here to pass -D_GLIBCXX_DEBUG when > building llvm. This switch turns on debug code in libstdc++ that checks for > various violations. We've already discovered several llvm bugs with it. > Should I commit a change back to the official sources? It will almost > certainly cause tests to fail, but that's a GOOD thing.Ooh cool. I'd strongly prefer that we fix the bugs in LLVM before enabling this :) -Chris -- http://nondot.org/sabre/ http://llvm.org/
On Thursday 07 June 2007 12:15, Chris Lattner wrote:> On Thu, 7 Jun 2007, David A. Greene wrote: > > I just made a patch to our local llvm build here to pass -D_GLIBCXX_DEBUG > > when building llvm. This switch turns on debug code in libstdc++ that > > checks for various violations. We've already discovered several llvm > > bugs with it. Should I commit a change back to the official sources? It > > will almost certainly cause tests to fail, but that's a GOOD thing. > > Ooh cool. I'd strongly prefer that we fix the bugs in LLVM before > enabling this :)Ok, I'll coordinate with Dan and Jeff and get our fixes back before I submit a change to enable this for debug builds. -Dave