llvm dev - Feb 2007 - [LLVMdev] LLVM Cygwin build RLIMIT_RSS configuration problem

On Sun, 2007-02-18 at 21:42 +0000, Aaron Gray wrote:
> Okay I have put a #ifdef HAVE_RLIMIT_RSS round the RSS code.
> 
> There needs to be logic added to config system to complement this.
> 
> Or shall I just use an #ifdef _CYGWIN_ ?
Please just use #ifdef _CYGWIN_
> 
> Regarding the Bytecode writer stuff. I will try adding some inline 
> dis-ambiguator functions.
Yeah, I can't help you solve this problem because I don't have your
environment or compiler. However, this really smells like a compiler or
stdint.h bug to me. This code compiles fine on many unix platforms and
also under mingw.

Reid.
> 
> Aaron
> 
> ----- Original Message ----- 
> From: "Reid Spencer" <rspencer at reidspencer.com>
> To: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu>
> Sent: Sunday, February 18, 2007 9:08 PM
> Subject: Re: [LLVMdev] LLVM Cygwin build RLIMIT_RSS configuration problem
> 
> 
> > Hi Aaron,
> >
> > On Sun, 2007-02-18 at 20:43 +0000, Aaron Gray wrote:
> >> Hi Reid,
> >>
> >> Cygwin 'sys/resource.h' has get/setrlimit() functions
support for
> >> RLIMIT_DATA and RLIMIT_AS but not RLIMIT_RSS.
> >
> > Then, please fix it to not use RLIMIT_RSS in the cygwin case. Perhaps
> > you should just use RLIMIT_AS for cygwin. It will trigger sooner than
> > RLIMIT_RSS but that's probably okay.
> >
> > Reid.
> >
> >>
> >> Aaron
> >>
> >> ----- Original Message ----- 
> >> From: "Reid Spencer" <rspencer at reidspencer.com>
> >> To: "LLVM Developers Mailing List" <llvmdev at
cs.uiuc.edu>
> >> Sent: Sunday, February 18, 2007 8:32 PM
> >> Subject: Re: [LLVMdev] LLVM Cygwin build RLIMIT_RSS configuration
problem
> >>
> >>
> >> > Hi Aaaron,
> >> >
> >> > On Sun, 2007-02-18 at 19:50 +0000, Aaron Gray wrote:
> >> >> In order to get Cygwin working there is a need to add a
> >> >> HAVE_RLIMIT_RSS and associated logic.
> >> >
> >> > This was just recently added. Does cygwin even have getrlimit
and
> >> > setrlimit?  IIRC correctly, it doesn't. So, perhaps these
functions
> >> > need
> >> > to be written differently for Cygwin. What's the
equivalent win32 call?
> >> >
> >> > If cygwin does have getrlimit/setrlimit then we'll have
to figure out
> >> > what RLIMIT_RSS should be under cygwin. Is there the notion
of running
> >> > set size under cygwin?
> >> >
> >> > Reid.
> >> >
> >> >>
> >> >> Aaron
> >> >>
> >> >>         ----- Original Message ----- 
> >> >>         From: Aaron Gray
> >> >>         To: LLVM Developers Mailing List
> >> >>         Sent: Sunday, February 18, 2007 7:00 PM
> >> >>         Subject: [LLVMdev] LLVM Cygwin build RLIMIT_RSS
configuration
> >> >>         problem
> >> >>
> >> >>
> >> >>         There seems to be a problem with the LLVM Cygwin
> >> >>         configuration. Cygwin does not support the
RLIMIT_RSS symbol.
> >> >>
> >> >>         llvm[1]: Compiling Program.cpp for Debug build
> >> >>         /usr/src/llvm/lib/System/Unix/Program.inc: In
function 'void
> >> >>         llvm::SetMemoryLimi
> >> >>         ts(unsigned int)':
> >> >>         /usr/src/llvm/lib/System/Unix/Program.inc:123:
error:
> >> >>         'RLIMIT_RSS' was not decla
> >> >>         red in this scope
> >> >>         make[1]: ***
[/usr/build/llvm/lib/System/Debug/Program.o]
> >> >>         Error 1
> >> >>         make[1]: Leaving directory
`/usr/build/llvm/lib/System'
> >> >>         make: *** [all] Error 1
> >> >>
> >> >>         I am not really up on LLVM configuration
otherwise I would
> >> >>         look into the problem myself.
> >> >>
> >> >>         Aaron
> >> >>
> >> >>
> >> >>        
______________________________________________________________
> >> >>
> >> >>         _______________________________________________
> >> >>         LLVM Developers mailing list
> >> >>         LLVMdev at cs.uiuc.edu        
http://llvm.cs.uiuc.edu
> >> >>         http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> >> >>
> >> >>
> >> >>
> >> >>        
______________________________________________________________
> >> >>
> >> >>         No virus found in this incoming message.
> >> >>         Checked by AVG Free Edition.
> >> >>         Version: 7.5.441 / Virus Database: 268.18.1/691 -
Release
> >> >>         Date: 17/02/2007 17:06
> >> >> _______________________________________________
> >> >> LLVM Developers mailing list
> >> >> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> >> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> >> >
> >> > _______________________________________________
> >> > LLVM Developers mailing list
> >> > LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> >> > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> >> >
> >> >
> >> > -- 
> >> > No virus found in this incoming message.
> >> > Checked by AVG Free Edition.
> >> > Version: 7.5.441 / Virus Database: 268.18.1/691 - Release
Date:
> >> > 17/02/2007
> >> > 17:06
> >> >
> >>
> >> _______________________________________________
> >> LLVM Developers mailing list
> >> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> >
> > _______________________________________________
> > LLVM Developers mailing list
> > LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> >
> >
> > -- 
> > No virus found in this incoming message.
> > Checked by AVG Free Edition.
> > Version: 7.5.441 / Virus Database: 268.18.1/691 - Release Date:
17/02/2007
> > 17:06
> > 
> 
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

> Please just use #ifdef _CYGWIN_
Okay
 
>> Regarding the Bytecode writer stuff. I will try adding some inline 
>> dis-ambiguator functions.
> 
> Yeah, I can't help you solve this problem because I don't have your
> environment or compiler. However, this really smells like a compiler or
> stdint.h bug to me. This code compiles fine on many unix platforms and
> also under mingw.
Okay I'll have a look at MinGW's stdint.h against Cygwin's.

Thanks,

Aaron

> Okay I'll have a look at MinGW's stdint.h against Cygwin's.
both int32_t and uint_32t are longs on Cygwin as compared to on MinGW they 
are int's.

I changed them in 'stdint.h' as a test and it compiles past Writer.cpp.

Not sure what to do about this in order to bring Cygwin build inline with 
*nix ?

The only way I can think of doing it is to provide some inline 
dis-ambiguation functions that would have no overhead other than source code 
overhead in WriterInternals.h.

Either that or patch Cygwin !

Aaron