llvm dev - Apr 2005 - [LLVMdev] Trailing whitespace removal (important for CVS users!)

Dear LLVMers,

If you live on the bleeding edge (i.e. CVS version), please read!

On Wed, Apr 20, 2005 at 12:12:54PM +0200, Markus F.X.J. Oberhumer
wrote:
> Do you really want external patches for this ? A simple Perl script
> that runs on all *.h and *.cpp files, and a local commit from your
> side would be much simpler. 
I'm in the process of doing just this as we speak.  What this means:
please hold off updating in the mean time, unless you want to rebuild
your codebase several times, as I am about to touch a *lot* of files.

I will send a message to the list when I'm done, so you can get all the
changes (and hopefully, few conflicts)
> The testsuite should also be enhanced to daily report files with
> trailing whitespace. 
Good idea, I'll add that to my todo list.
> Please note that this not purely academic - trailing whitespace are a
> horror for anyone maintaining external patches against a CVS tree.
I was not aware that this is such a big problem, so thanks for point
this out.  It'll be fixed in a short while.

-- 
Misha Brukman :: http://misha.brukman.net :: http://llvm.cs.uiuc.edu

Why not put all this into a pre-commit filter in CVS and be done with
it? We'd never be bothered with it again as it would never be committed
again.

Reid.

On Thu, 2005-04-21 at 15:11 -0500, Misha Brukman wrote:
> Dear LLVMers,
> 
> If you live on the bleeding edge (i.e. CVS version), please read!
> 
> On Wed, Apr 20, 2005 at 12:12:54PM +0200, Markus F.X.J. Oberhumer wrote:
> > Do you really want external patches for this ? A simple Perl script
> > that runs on all *.h and *.cpp files, and a local commit from your
> > side would be much simpler. 
> 
> I'm in the process of doing just this as we speak.  What this means:
> please hold off updating in the mean time, unless you want to rebuild
> your codebase several times, as I am about to touch a *lot* of files.
> 
> I will send a message to the list when I'm done, so you can get all the
> changes (and hopefully, few conflicts)
> 
> > The testsuite should also be enhanced to daily report files with
> > trailing whitespace. 
> 
> Good idea, I'll add that to my todo list.
> 
> > Please note that this not purely academic - trailing whitespace are a
> > horror for anyone maintaining external patches against a CVS tree.
> 
> I was not aware that this is such a big problem, so thanks for point
> this out.  It'll be fixed in a short while.
> 


_______________________
Reid Spencer
President & CTO
eXtensible Systems, Inc.
rspencer at x10sys.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20050421/610805ee/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20050421/610805ee/attachment.sig>

On Thu, 21 Apr 2005, Reid Spencer wrote:
> Why not put all this into a pre-commit filter in CVS and be done with
> it? We'd never be bothered with it again as it would never be committed
> again.
I'd rather not have CVS commit scripts mucking with the code.  If you want 
to have the nightly tester whine about source code with spaces at the end 
of lines (like it whines about compiler warnings), that would be fine.

BTW, does anyone know how to tell xemacs to autodelete end of line spaces?

-Chris
>> Dear LLVMers,
>>
>> If you live on the bleeding edge (i.e. CVS version), please read!
>>
>> On Wed, Apr 20, 2005 at 12:12:54PM +0200, Markus F.X.J. Oberhumer
wrote:
>>> Do you really want external patches for this ? A simple Perl script
>>> that runs on all *.h and *.cpp files, and a local commit from your
>>> side would be much simpler.
>>
>> I'm in the process of doing just this as we speak.  What this
means:
>> please hold off updating in the mean time, unless you want to rebuild
>> your codebase several times, as I am about to touch a *lot* of files.
>>
>> I will send a message to the list when I'm done, so you can get all
the
>> changes (and hopefully, few conflicts)
>>
>>> The testsuite should also be enhanced to daily report files with
>>> trailing whitespace.
>>
>> Good idea, I'll add that to my todo list.
>>
>>> Please note that this not purely academic - trailing whitespace are
a
>>> horror for anyone maintaining external patches against a CVS tree.
>>
>> I was not aware that this is such a big problem, so thanks for point
>> this out.  It'll be fixed in a short while.
>>
>
>
>
> _______________________
> Reid Spencer
> President & CTO
> eXtensible Systems, Inc.
> rspencer at x10sys.com
>
-Chris

-- 
http://nondot.org/sabre/
http://llvm.cs.uiuc.edu/

Dear LLVMers,

The "trailing whitespace removal" part of the "spring
cleaning" of the
LLVM codebase is complete.  Feel free to update, but you should know
that it'll force a compete rebuild of your tree.

Nate "Sampo" Begeman asked for some fun stats, so I've calculated
that
the size of the codebase has decreased by 0.256% or 19kb as a result of
this change.

-- 
Misha Brukman :: http://misha.brukman.net :: http://llvm.cs.uiuc.edu

On Fri, Apr 22, 2005 at 02:21:05AM +0200, Markus F.X.J. Oberhumer
wrote:
> Many thanks - attached you will find a list of files you still might 
> want to consider.
Hmmm, those pesky .c and .in files, but I thought I covered all the .h
and .cpp files... darn.

OK, I'll trade you -- can you tell me how I can grep for a tab within a
file?  The following don't work for me:

grep '\t' 
grep '^T' 
grep '^I' 

Tried with grep and egrep.

-- 
Misha Brukman :: http://misha.brukman.net :: http://llvm.cs.uiuc.edu

On Thu, Apr 21, 2005 at 07:26:00PM -0500, Misha Brukman
wrote:
> OK, I'll trade you -- can you tell me how I can grep for a tab within a
> file?  The following don't work for me:
> 
> grep '\t' 
> grep '^T' 
> grep '^I' 
> 
> Tried with grep and egrep.
I think the problem is the shell. Try grep "`printf '\t'`"
See
http://lists.gnu.org/archive/html/bug-textutils/2002-06/msg00019.html

I often use perl in these sorts of cases ...
find | xargs perl -n -e '/\t$/ and print'

Lurker Tom

-- 
Tom Brown   tdbrown at uiuc.edu   Siebel Center 2107   +1 (217) 778-7908