Reid Spencer
2004-Dec-04 05:07 UTC
[LLVMdev] [Fwd: Updated LLVM Visual Studio project files]
ltdl.h fully supports windows platforms (lots of them). That isn't the issue. The issue is setting up the #defines to reflect the windows system. e.g. HAVE_DLOPEN needs to be false Reid. On Fri, 2004-12-03 at 20:35, Chris Lattner wrote:> On Fri, 3 Dec 2004, Jeff Cohen wrote: > > > It will have to be Morten. I can't get ltdl.c to compile. But wasn't > > the whole point of doing platform-specific DynamicLibrary.cpps to get > > rid of ltdl.c? > > ltdl.c is part of libtool that is supposed to BE the cross-platform > dynamic linker interface. However, for platforms it doesn't really > support, using custom code makes perfect sense. > > -Chris > > > > On Fri, 3 Dec 2004 10:40:53 -0600 (CST) > > Chris Lattner <sabre at nondot.org> wrote: > > > > > On Fri, 3 Dec 2004, Reid Spencer wrote: > > > > > > > Could someone please apply this patch to the Win32 support so that > > > > Morten and Jeff can handle the recent changes? I can't do it because > > > > I"m on the road with only email access. > > > > > > I'd be happy to do it. Can someone send me the patch as an attachment > > > off-list? > > > > > > -Chris > > > > _______________________________________________ > > LLVM Developers mailing list > > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > > http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev > > > > -Chris-------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20041203/0f98f974/attachment.sig>
Jeff Cohen
2004-Dec-05 17:08 UTC
[LLVMdev] [Fwd: Updated LLVM Visual Studio project files]
Well, then why does win32/DynamicLibrary.cpp exist, not to mention it's *nix relatives? You have even been updating them, even though they cannot be compiled as they aren't included by System/DynamicLibrary.cpp. Anyway, with Morten's patches I can almost build successfully. Minor patch attached to fix the residual problems. I don't know why he didn't hit these problems. And speaking of ltdl.c, it doesn't build cleanly with VC++: \llvm\lib\System\ltdl.c(972) : warning C4090: 'function' : different 'const' qualifiers \llvm\lib\System\ltdl.c(1332) : warning C4090: '=' : different 'const' qualifiers \llvm\lib\System\ltdl.c(1431) : warning C4113: 'lt_module (__cdecl *)()' differs in parameter lists from 'lt_module_open (__cdecl *)' \llvm\lib\System\ltdl.c(1431) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'lt_module_close (__cdecl *)' \llvm\lib\System\ltdl.c(1431) : warning C4113: 'void *(__cdecl *)()' differs in parameter lists from 'lt_find_sym (__cdecl *)' \llvm\lib\System\ltdl.c(2121) : warning C4113: 'lt_module (__cdecl *)()' differs in parameter lists from 'lt_module_open (__cdecl *)' \llvm\lib\System\ltdl.c(2121) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'lt_module_close (__cdecl *)' \llvm\lib\System\ltdl.c(2121) : warning C4113: 'void *(__cdecl *)()' differs in parameter lists from 'lt_find_sym (__cdecl *)' \llvm\lib\System\ltdl.c(2121) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'lt_dlloader_exit (__cdecl *)' \llvm\lib\System\ltdl.c(2742) : warning C4090: 'initializing' : different 'const' qualifiers \llvm\lib\System\ltdl.c(2775) : warning C4013: 'access' undefined; assuming extern returning int \llvm\lib\System\ltdl.c(3089) : warning C4090: '=' : different 'const' qualifiers \llvm\lib\System\ltdl.c(3284) : warning C4090: '=' : different 'const' qualifiers \llvm\lib\System\ltdl.c(3462) : warning C4090: '=' : different 'const' qualifiers I tried to clean them up, but I wound up playing wack-a-mole. Fixing one warning caused others to take its place. Oh well... it is C code after all... On Fri, 03 Dec 2004 21:07:21 -0800 Reid Spencer <reid at x10sys.com> wrote:> ltdl.h fully supports windows platforms (lots of them). That isn't the > issue. The issue is setting up the #defines to reflect the windows > system. e.g. HAVE_DLOPEN needs to be false > > Reid. > > On Fri, 2004-12-03 at 20:35, Chris Lattner wrote: > > On Fri, 3 Dec 2004, Jeff Cohen wrote: > > > > > It will have to be Morten. I can't get ltdl.c to compile. But wasn't > > > the whole point of doing platform-specific DynamicLibrary.cpps to get > > > rid of ltdl.c? > > > > ltdl.c is part of libtool that is supposed to BE the cross-platform > > dynamic linker interface. However, for platforms it doesn't really > > support, using custom code makes perfect sense. > > > > -Chris > > > > > > > On Fri, 3 Dec 2004 10:40:53 -0600 (CST) > > > Chris Lattner <sabre at nondot.org> wrote: > > > > > > > On Fri, 3 Dec 2004, Reid Spencer wrote: > > > > > > > > > Could someone please apply this patch to the Win32 support so that > > > > > Morten and Jeff can handle the recent changes? I can't do it because > > > > > I"m on the road with only email access. > > > > > > > > I'd be happy to do it. Can someone send me the patch as an attachment > > > > off-list? > > > > > > > > -Chris > > > > > > _______________________________________________ > > > LLVM Developers mailing list > > > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > > > http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev > > > > > > > -Chris >-------------- next part -------------- A non-text attachment was scrubbed... Name: diff.out Type: application/octet-stream Size: 3025 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20041205/1765c614/attachment.obj>
Morten Ofstad
2004-Dec-06 09:24 UTC
[LLVMdev] [Fwd: Updated LLVM Visual Studio project files]
Jeff Cohen wrote:> Anyway, with Morten's patches I can almost build successfully. Minor > patch attached to fix the residual problems. I don't know why he didn't > hit these problems.The simple explanation is that I forgot to submit the patch for the missing #include <stddef.h> in DataTypes.h.in -- The other part of your patch I guess is to get rid of the ugly casts? At least I didn't have to do this to get it to compile... m.
Reid Spencer
2004-Dec-28 06:31 UTC
[LLVMdev] [Fwd: Updated LLVM Visual Studio project files]
Hi Jeff, I'm just reviewing some old mail on my "to do" list. I was wondering if you managed to get ltdl.c to compile cleanly with VC++ or if you want me to look at these warnings. Reid. On Sun, 2004-12-05 at 09:08, Jeff Cohen wrote:> Well, then why does win32/DynamicLibrary.cpp exist, not to mention it's > *nix relatives? You have even been updating them, even though they > cannot be compiled as they aren't included by System/DynamicLibrary.cpp. > > Anyway, with Morten's patches I can almost build successfully. Minor > patch attached to fix the residual problems. I don't know why he didn't > hit these problems. > > And speaking of ltdl.c, it doesn't build cleanly with VC++: > > \llvm\lib\System\ltdl.c(972) : warning C4090: 'function' : different 'const' qualifiers > \llvm\lib\System\ltdl.c(1332) : warning C4090: '=' : different 'const' qualifiers > \llvm\lib\System\ltdl.c(1431) : warning C4113: 'lt_module (__cdecl *)()' differs in parameter lists from 'lt_module_open (__cdecl *)' > \llvm\lib\System\ltdl.c(1431) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'lt_module_close (__cdecl *)' > \llvm\lib\System\ltdl.c(1431) : warning C4113: 'void *(__cdecl *)()' differs in parameter lists from 'lt_find_sym (__cdecl *)' > \llvm\lib\System\ltdl.c(2121) : warning C4113: 'lt_module (__cdecl *)()' differs in parameter lists from 'lt_module_open (__cdecl *)' > \llvm\lib\System\ltdl.c(2121) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'lt_module_close (__cdecl *)' > \llvm\lib\System\ltdl.c(2121) : warning C4113: 'void *(__cdecl *)()' differs in parameter lists from 'lt_find_sym (__cdecl *)' > \llvm\lib\System\ltdl.c(2121) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'lt_dlloader_exit (__cdecl *)' > \llvm\lib\System\ltdl.c(2742) : warning C4090: 'initializing' : different 'const' qualifiers > \llvm\lib\System\ltdl.c(2775) : warning C4013: 'access' undefined; assuming extern returning int > \llvm\lib\System\ltdl.c(3089) : warning C4090: '=' : different 'const' qualifiers > \llvm\lib\System\ltdl.c(3284) : warning C4090: '=' : different 'const' qualifiers > \llvm\lib\System\ltdl.c(3462) : warning C4090: '=' : different 'const' qualifiers > > I tried to clean them up, but I wound up playing wack-a-mole. Fixing > one warning caused others to take its place. Oh well... it is C code > after all... > > > On Fri, 03 Dec 2004 21:07:21 -0800 > Reid Spencer <reid at x10sys.com> wrote: > > > ltdl.h fully supports windows platforms (lots of them). That isn't the > > issue. The issue is setting up the #defines to reflect the windows > > system. e.g. HAVE_DLOPEN needs to be false > > > > Reid. > > > > On Fri, 2004-12-03 at 20:35, Chris Lattner wrote: > > > On Fri, 3 Dec 2004, Jeff Cohen wrote: > > > > > > > It will have to be Morten. I can't get ltdl.c to compile. But wasn't > > > > the whole point of doing platform-specific DynamicLibrary.cpps to get > > > > rid of ltdl.c? > > > > > > ltdl.c is part of libtool that is supposed to BE the cross-platform > > > dynamic linker interface. However, for platforms it doesn't really > > > support, using custom code makes perfect sense. > > > > > > -Chris > > > > > > > > > > On Fri, 3 Dec 2004 10:40:53 -0600 (CST) > > > > Chris Lattner <sabre at nondot.org> wrote: > > > > > > > > > On Fri, 3 Dec 2004, Reid Spencer wrote: > > > > > > > > > > > Could someone please apply this patch to the Win32 support so that > > > > > > Morten and Jeff can handle the recent changes? I can't do it because > > > > > > I"m on the road with only email access. > > > > > > > > > > I'd be happy to do it. Can someone send me the patch as an attachment > > > > > off-list? > > > > > > > > > > -Chris > > > > > > > > _______________________________________________ > > > > LLVM Developers mailing list > > > > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > > > > http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev > > > > > > > > > > -Chris > > > > ______________________________________________________________________ > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev-------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20041227/9239f5c8/attachment.sig>