On Fri, 2004-11-12 at 12:50, Chris Lattner wrote:> On Fri, 12 Nov 2004, Reid Spencer wrote:> Maybe the llvm-test module should have a config.h file?perhaps, but that means modifying all the programs to use it as well and a lot of them have their own config.h because they are supposed to be configured as well.> Or perhaps > llvm-test should use the main llvm compatibility headers?perhaps, but again that requires the test programs to be modified.> We've already > solved *this* issue with include/llvm/Config/alloca.h right?yes, a month or so ago. Reid. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20041112/192a6fcf/attachment.sig>
On Fri, 12 Nov 2004, Reid Spencer wrote:> On Fri, 2004-11-12 at 12:32, Chris Lattner wrote: > > > Perhaps the right way to handle this particular problem is to add the > > appropriate autoconf check to the llvm-test configure, then have the > > programs that need alloca use the detected value? > > Its already in the llvm configure which is inherited by llvm-test. If > you want to define this in the makefiles, add the following to > llvm-test/Makefile.config.in: > > HAVE_ALLOCA_H = @HAVE_ALLOCA_H@Maybe the llvm-test module should have a config.h file? Or perhaps llvm-test should use the main llvm compatibility headers? We've already solved *this* issue with include/llvm/Config/alloca.h right? -Chris -- http://llvm.org/ http://nondot.org/sabre/
On Fri, 12 Nov 2004, Reid Spencer wrote:> On Fri, 2004-11-12 at 12:50, Chris Lattner wrote: > > On Fri, 12 Nov 2004, Reid Spencer wrote: > > Maybe the llvm-test module should have a config.h file? > > perhaps, but that means modifying all the programs to use it as well and > a lot of them have their own config.h because they are supposed to be > configured as well.We wouldn't need to have a configure script for each program, just union all of the checks into the top level llvm-test configure.> > Or perhaps > > llvm-test should use the main llvm compatibility headers? > > perhaps, but again that requires the test programs to be modified.That is not a problem. -Chris -- http://llvm.org/ http://nondot.org/sabre/