<algorithm> works too. On Fri, 24 Sep 2004 10:09:21 -0500 Alkis Evlogimenos <alkis at cs.uiuc.edu> wrote:> On Fri, 2004-09-24 at 09:43, Paolo Invernizzi wrote: > > Jeff Cohen wrote: > > > > >But I compiled that under vc7.1 as it was! > > > > > > > > ;-(( > > > > Probably is an implicid includes, but I'm using the STLPort standard > > library for LLVM (because it's not possible to use hash_map and hash_set > > of microsoft) > > std::remove is in <algorithm> > > -- > > Alkis > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev
Actually, <algorithm> is not correct. This remove is in stdio.h and io.h in VC7.1. It removes a file, not elements from a collection. The proper solution is to not use remove at all and use Path::destroy_file(). On Fri, 24 Sep 2004 08:09:37 -0700 Jeff Cohen <jeffc at jolt-lang.org> wrote:> <algorithm> works too. > > On Fri, 24 Sep 2004 10:09:21 -0500 > Alkis Evlogimenos <alkis at cs.uiuc.edu> wrote: > > > On Fri, 2004-09-24 at 09:43, Paolo Invernizzi wrote: > > > Jeff Cohen wrote: > > > > > > >But I compiled that under vc7.1 as it was! > > > > > > > > > > > ;-(( > > > > > > Probably is an implicid includes, but I'm using the STLPort standard > > > library for LLVM (because it's not possible to use hash_map and hash_set > > > of microsoft) > > > > std::remove is in <algorithm> > > > > -- > > > > Alkis > > > > _______________________________________________ > > LLVM Developers mailing list > > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > > http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev
Paulo, If <algorithm> works for you, I'd rather implement that. Please let me know. Reid. On Fri, 2004-09-24 at 08:09, Jeff Cohen wrote:> <algorithm> works too. > > On Fri, 24 Sep 2004 10:09:21 -0500 > Alkis Evlogimenos <alkis at cs.uiuc.edu> wrote: > > > On Fri, 2004-09-24 at 09:43, Paolo Invernizzi wrote: > > > Jeff Cohen wrote: > > > > > > >But I compiled that under vc7.1 as it was! > > > > > > > > > > > ;-(( > > > > > > Probably is an implicid includes, but I'm using the STLPort standard > > > library for LLVM (because it's not possible to use hash_map and hash_set > > > of microsoft) > > > > std::remove is in <algorithm> > > > > -- > > > > Alkis > > > > _______________________________________________ > > LLVM Developers mailing list > > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > > http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev-------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20040924/3c842070/attachment.sig>
On Fri, Sep 24, 2004 at 08:17:41AM -0700, Jeff Cohen wrote:> Actually, <algorithm> is not correct. This remove is in stdio.h and > io.h in VC7.1. It removes a file, not elements from a collection. > > The proper solution is to not use remove at all and use > Path::destroy_file().But don't you want to use ::remove instead of std::remove then? -- Misha Brukman :: http://misha.brukman.net :: http://llvm.cs.uiuc.edu
On Fri, 2004-09-24 at 08:17, Jeff Cohen wrote:> Actually, <algorithm> is not correct. This remove is in stdio.h and > io.h in VC7.1. It removes a file, not elements from a collection. > > The proper solution is to not use remove at all and use > Path::destroy_file().Yes. I'm currently working on "Block", "File" and "MappedFile" abstractions for lib/System. When done, these abstractions will take care of the bulks of the remaining system dependent behavior in LLVM. Unfortunately, the conversion from the XPS code is somewhat tedious for LLVM standards. Anyway, hope to do this on the plane tomorrow. Reid. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20040924/eb9e76fa/attachment.sig>
Jeff Cohen wrote:><algorithm> works too. > >For std::remove yes... but... d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(179) : error C2065: 'stderr' : undeclared identifier d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(179) : error C3861: 'fprintf': identifier not found, even with argument-dependent lookup d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(182) : error C3861: 'fprintf': identifier not found, even with argument-dependent lookup d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(182) : error C3861: 'stderr': identifier not found, even with argument-dependent lookup d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(187) : error C3861: 'fputs': identifier not found, even with argument-dependent lookup d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(187) : error C3861: 'stderr': identifier not found, even with argument-dependent lookup d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(200) : error C3861: 'fputc': identifier not found, even with argument-dependent lookup d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(200) : error C3861: 'stderr': identifier not found, even with argument-dependent lookup d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(206) : error C3861: 'fprintf': identifier not found, even with argument-dependent lookup d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(206) : error C3861: 'stderr': identifier not found, even with argument-dependent lookup d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(208) : error C3861: 'fprintf': identifier not found, even with argument-dependent lookup d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(208) : error C3861: 'stderr': identifier not found, even with argument-dependent lookup d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(215) : error C3861: 'fprintf': identifier not found, even with argument-dependent lookup d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(215) : error C3861: 'stderr': identifier not found, even with argument-dependent lookup d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(217) : error C3861: 'fprintf': identifier not found, even with argument-dependent lookup d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(217) : error C3861: 'stderr': identifier not found, even with argument-dependent lookup d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(220) : error C3861: 'fputc': identifier not found, even with argument-dependent lookup d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(220) : error C3861: 'stderr': identifier not found, even with argument-dependent lookup --- Paolo Invernizzi
On Fri, Sep 24, 2004 at 05:32:08PM +0200, Paolo Invernizzi wrote:> Jeff Cohen wrote: > > ><algorithm> works too. > > > > > For std::remove yes... but... > > d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(179) > : error C2065: 'stderr' : undeclared identifier > d:\home\arathorn\sandbox\llvm\llvm\lib\System\platform\Signals.cpp(179) > : error C3861: 'fprintf': identifier not found, even with > argument-dependent lookupThese should all be prepended with ::, methinks, to label them as coming from the global namespace... For one, as example I'm seeing the following in Unix/Path.cpp: int fd = ::creat(path.c_str(), S_IRUSR | S_IWUSR); -- Misha Brukman :: http://misha.brukman.net :: http://llvm.cs.uiuc.edu