On Sat, 18 Sep 2004 12:30:41 -0700 Reid Spencer <reid at x10sys.com> wrote:> Patch looks good so I committed it. I'd be interested in knowing what > your test results are once you start testing with the Win32 port.I tested Signals.cpp and verified that the CTRL/C handler works, as does the stack trace. In fact, here's a sample: 77E73887 (0xE06D7363 0x00000001 0x00000003 0x0012FF28), RaiseException()+0080 bytes(s) 10226DB9 (0x0012FF44 0x0040DEFC 0x00020024 0x00647373), _CxxThrowException()+0057 bytes(s) 00401822 (0x0012FFC0 0x00409A2C 0x00000001 0x003250D0), XYZ::func()+0034 bytes(s), c:\projects\llvm\test.cpp, line 12 004017ED (0x00000001 0x003250D0 0x00322C68 0x00020024), main()+0013 bytes(s), c:\projects\llvm\test.cpp, line 19 00409A2C (0x00020024 0x7FFDF000 0x7FFDF000 0xF3893CF0), mainCRTStartup()+0300 bytes(s), f:\vs70builds\3077\vc\crtbld\crt\src\crtexe.c, line 398+0017 byte(s) 77E814C7 (0x00409900 0x00000000 0x78746341 0x00000020), GetCurrentDirectoryW()+0068 bytes(s) However, for some reason I haven't been able to determine, the lovely trace you see above comes out only on Windows XP. On Windows 2000, it can't get the symbol information for EXEs, though it does for DLLs. I know this code worked on 2000 in the past, so it must be something that broke with VC 7.1. Oh well. (The GetCurrentDirectoryW is bogus, but the top of the stack usually is). I did make some minor changes that I'll submit shortly.
Patch for Signals.cpp attached. On Sat, 18 Sep 2004 21:30:12 -0700 Jeff Cohen <jeffc at jolt-lang.org> wrote:> On Sat, 18 Sep 2004 12:30:41 -0700 > Reid Spencer <reid at x10sys.com> wrote: > > > Patch looks good so I committed it. I'd be interested in knowing what > > your test results are once you start testing with the Win32 port. > > I tested Signals.cpp and verified that the CTRL/C handler works, as does > the stack trace. In fact, here's a sample: > > 77E73887 (0xE06D7363 0x00000001 0x00000003 0x0012FF28), RaiseException()+0080 bytes(s) > 10226DB9 (0x0012FF44 0x0040DEFC 0x00020024 0x00647373), _CxxThrowException()+0057 bytes(s) > 00401822 (0x0012FFC0 0x00409A2C 0x00000001 0x003250D0), XYZ::func()+0034 bytes(s), c:\projects\llvm\test.cpp, line 12 > 004017ED (0x00000001 0x003250D0 0x00322C68 0x00020024), main()+0013 bytes(s), c:\projects\llvm\test.cpp, line 19 > 00409A2C (0x00020024 0x7FFDF000 0x7FFDF000 0xF3893CF0), mainCRTStartup()+0300 bytes(s), f:\vs70builds\3077\vc\crtbld\crt\src\crtexe.c, line 398+0017 byte(s) > 77E814C7 (0x00409900 0x00000000 0x78746341 0x00000020), GetCurrentDirectoryW()+0068 bytes(s) > > However, for some reason I haven't been able to determine, the lovely > trace you see above comes out only on Windows XP. On Windows 2000, it > can't get the symbol information for EXEs, though it does for DLLs. I > know this code worked on 2000 in the past, so it must be something that > broke with VC 7.1. Oh well. > > (The GetCurrentDirectoryW is bogus, but the top of the stack usually is). > > I did make some minor changes that I'll submit shortly. > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev-------------- next part -------------- A non-text attachment was scrubbed... Name: Signals.diff Type: application/octet-stream Size: 4053 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20040918/27ca31e3/attachment.obj>
Patch committed. Thanks for cleaning up some of the coding standards issues. Reid. On Sat, 2004-09-18 at 22:18, Jeff Cohen wrote:> Patch for Signals.cpp attached. > > On Sat, 18 Sep 2004 21:30:12 -0700 > Jeff Cohen <jeffc at jolt-lang.org> wrote: > > > On Sat, 18 Sep 2004 12:30:41 -0700 > > Reid Spencer <reid at x10sys.com> wrote: > > > > > Patch looks good so I committed it. I'd be interested in knowing what > > > your test results are once you start testing with the Win32 port. > > > > I tested Signals.cpp and verified that the CTRL/C handler works, as does > > the stack trace. In fact, here's a sample: > > > > 77E73887 (0xE06D7363 0x00000001 0x00000003 0x0012FF28), RaiseException()+0080 bytes(s) > > 10226DB9 (0x0012FF44 0x0040DEFC 0x00020024 0x00647373), _CxxThrowException()+0057 bytes(s) > > 00401822 (0x0012FFC0 0x00409A2C 0x00000001 0x003250D0), XYZ::func()+0034 bytes(s), c:\projects\llvm\test.cpp, line 12 > > 004017ED (0x00000001 0x003250D0 0x00322C68 0x00020024), main()+0013 bytes(s), c:\projects\llvm\test.cpp, line 19 > > 00409A2C (0x00020024 0x7FFDF000 0x7FFDF000 0xF3893CF0), mainCRTStartup()+0300 bytes(s), f:\vs70builds\3077\vc\crtbld\crt\src\crtexe.c, line 398+0017 byte(s) > > 77E814C7 (0x00409900 0x00000000 0x78746341 0x00000020), GetCurrentDirectoryW()+0068 bytes(s) > > > > However, for some reason I haven't been able to determine, the lovely > > trace you see above comes out only on Windows XP. On Windows 2000, it > > can't get the symbol information for EXEs, though it does for DLLs. I > > know this code worked on 2000 in the past, so it must be something that > > broke with VC 7.1. Oh well. > > > > (The GetCurrentDirectoryW is bogus, but the top of the stack usually is). > > > > I did make some minor changes that I'll submit shortly. > > > > _______________________________________________ > > LLVM Developers mailing list > > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > > http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev > > ______________________________________________________________________ > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev-------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20040918/83844406/attachment.sig>