Linux Virtualization - Nov 2023 - virtcrypto_dataq_callback calls crypto_finalize_request() from irq context

On Sun, Sep 24, 2023 at 07:39:41PM +0200, Halil Pasic
wrote:
> On Sun, 24 Sep 2023 11:56:25 +0000
> "Gonglei (Arei)" <arei.gonglei at huawei.com> wrote:
> 
> > Hi Halil,
> > 
> > Commit 4058cf08945 introduced a check for detecting crypto completion
function
> > called with enable BH, and indeed the virtio-crypto driver didn't
disable BH, which needs
> > a patch to fix it.
> > 
> > P.S.: https://lore.kernel.org/lkml/20220221120833.2618733-5-clabbe at
baylibre.com/T/
> > 
> > Regards,
> > -Gonglei
> 
> Thanks Gonglei!
> 
> Thanks! I would be glad to test that fix on s390x. Are you about to send
> one?
> 
> Regards,
> Halil

Gonglei did you intend to send a fix?

> -----Original Message-----
> From: Michael S. Tsirkin [mailto:mst at redhat.com]
> Sent: Wednesday, November 1, 2023 9:26 PM
> To: Halil Pasic <pasic at linux.ibm.com>
> Cc: Gonglei (Arei) <arei.gonglei at huawei.com>; Herbert Xu
> <herbert at gondor.apana.org.au>; Jason Wang <jasowang at
redhat.com>;
> virtualization at lists.linux-foundation.org; linux-kernel at
vger.kernel.org;
> linux-crypto at vger.kernel.org; Marc Hartmayer <mhartmay at
linux.ibm.com>
> Subject: Re: virtcrypto_dataq_callback calls crypto_finalize_request() from
irq
> context
> 
> On Sun, Sep 24, 2023 at 07:39:41PM +0200, Halil Pasic wrote:
> > On Sun, 24 Sep 2023 11:56:25 +0000
> > "Gonglei (Arei)" <arei.gonglei at huawei.com> wrote:
> >
> > > Hi Halil,
> > >
> > > Commit 4058cf08945 introduced a check for detecting crypto
> > > completion function called with enable BH, and indeed the
> > > virtio-crypto driver didn't disable BH, which needs a patch
to fix it.
> > >
> > > P.S.:
> > > https://lore.kernel.org/lkml/20220221120833.2618733-5-clabbe at
baylibr
> > > e.com/T/
> > >
> > > Regards,
> > > -Gonglei
> >
> > Thanks Gonglei!
> >
> > Thanks! I would be glad to test that fix on s390x. Are you about to
> > send one?
> >
> > Regards,
> > Halil
> 
> 
> Gonglei did you intend to send a fix?
Actually I sent a patch a month ago, pls see another thread.


Regards,
-Gonglei

On Thu, Nov 02, 2023 at 01:04:07PM +0000, Gonglei (Arei)
wrote:
> 
> 
> > -----Original Message-----
> > From: Michael S. Tsirkin [mailto:mst at redhat.com]
> > Sent: Wednesday, November 1, 2023 9:26 PM
> > To: Halil Pasic <pasic at linux.ibm.com>
> > Cc: Gonglei (Arei) <arei.gonglei at huawei.com>; Herbert Xu
> > <herbert at gondor.apana.org.au>; Jason Wang <jasowang at
redhat.com>;
> > virtualization at lists.linux-foundation.org; linux-kernel at
vger.kernel.org;
> > linux-crypto at vger.kernel.org; Marc Hartmayer <mhartmay at
linux.ibm.com>
> > Subject: Re: virtcrypto_dataq_callback calls crypto_finalize_request()
from irq
> > context
> > 
> > On Sun, Sep 24, 2023 at 07:39:41PM +0200, Halil Pasic wrote:
> > > On Sun, 24 Sep 2023 11:56:25 +0000
> > > "Gonglei (Arei)" <arei.gonglei at huawei.com>
wrote:
> > >
> > > > Hi Halil,
> > > >
> > > > Commit 4058cf08945 introduced a check for detecting crypto
> > > > completion function called with enable BH, and indeed the
> > > > virtio-crypto driver didn't disable BH, which needs a
patch to fix it.
> > > >
> > > > P.S.:
> > > > https://lore.kernel.org/lkml/20220221120833.2618733-5-clabbe
at baylibr
> > > > e.com/T/
> > > >
> > > > Regards,
> > > > -Gonglei
> > >
> > > Thanks Gonglei!
> > >
> > > Thanks! I would be glad to test that fix on s390x. Are you about
to
> > > send one?
> > >
> > > Regards,
> > > Halil
> > 
> > 
> > Gonglei did you intend to send a fix?
> 
> Actually I sent a patch a month ago, pls see another thread.
> 
> 
> Regards,
> -Gonglei
And I think there was an issue with that patch that you
wanted to fix?
config changed callback got fixed but this still didn't.

-- 
MST