Jason Wang
2023-Sep-22 04:26 UTC
[PATCH net 3/6] virtio-net: consistently save parameters for per-queue
On Tue, Sep 19, 2023 at 3:49?PM Heng Qi <hengqi at linux.alibaba.com> wrote:> > When using .set_coalesce interface to set all queue coalescing > parameters, we need to update both per-queue and global save values. > > Fixes: 394bd87764b6 ("virtio_net: support per queue interrupt coalesce command") > Cc: Gavin Li <gavinl at nvidia.com> > Signed-off-by: Heng Qi <hengqi at linux.alibaba.com>Acked-by: Jason Wang <jasowang at redhat.com> Thanks> --- > drivers/net/virtio_net.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 80d35a864790..ce60162d380a 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -3233,6 +3233,7 @@ static int virtnet_send_notf_coal_cmds(struct virtnet_info *vi, > struct ethtool_coalesce *ec) > { > struct scatterlist sgs_tx, sgs_rx; > + int i; > > vi->ctrl->coal_tx.tx_usecs = cpu_to_le32(ec->tx_coalesce_usecs); > vi->ctrl->coal_tx.tx_max_packets = cpu_to_le32(ec->tx_max_coalesced_frames); > @@ -3246,6 +3247,10 @@ static int virtnet_send_notf_coal_cmds(struct virtnet_info *vi, > /* Save parameters */ > vi->intr_coal_tx.max_usecs = ec->tx_coalesce_usecs; > vi->intr_coal_tx.max_packets = ec->tx_max_coalesced_frames; > + for (i = 0; i < vi->max_queue_pairs; i++) { > + vi->sq[i].intr_coal.max_usecs = ec->tx_coalesce_usecs; > + vi->sq[i].intr_coal.max_packets = ec->tx_max_coalesced_frames; > + } > > vi->ctrl->coal_rx.rx_usecs = cpu_to_le32(ec->rx_coalesce_usecs); > vi->ctrl->coal_rx.rx_max_packets = cpu_to_le32(ec->rx_max_coalesced_frames); > @@ -3259,6 +3264,10 @@ static int virtnet_send_notf_coal_cmds(struct virtnet_info *vi, > /* Save parameters */ > vi->intr_coal_rx.max_usecs = ec->rx_coalesce_usecs; > vi->intr_coal_rx.max_packets = ec->rx_max_coalesced_frames; > + for (i = 0; i < vi->max_queue_pairs; i++) { > + vi->rq[i].intr_coal.max_usecs = ec->rx_coalesce_usecs; > + vi->rq[i].intr_coal.max_packets = ec->rx_max_coalesced_frames; > + } > > return 0; > } > -- > 2.19.1.6.gb485710b >