On Tue, Apr 18, 2023 at 2:58?AM Jakub Kicinski <kuba at kernel.org>
wrote:>
> On Mon, 17 Apr 2023 11:56:10 -0700 Jakub Kicinski wrote:
> > > May misunderstand, here the "dma_ops" is not the
"dma_ops" of DMA API.
> > >
> > > I mean the callbacks for xsk to do dma.
> > >
> > > Maybe, I should rename it in the next version.
> >
> > Would you mind explaining this a bit more to folks like me who are not
> > familiar with VirtIO? DMA API is supposed to hide the DMA mapping
> > details from the stack, why is it not sufficient here.
The reason is that legacy virtio device don't use DMA(vring_use_dma_api()).
The AF_XDP assumes DMA for netdev doesn't work in this case. We need a
way to make it work.
Thanks
>
> Umm.. also it'd help to post the user of the API in the same series.
> I only see the XSK changes, maybe if the virtio changes were in
> the same series I could answer my own question.
>