Stefan Hajnoczi
2023-Mar-28 14:51 UTC
[virtio-dev] [PATCH 2/2] virtio-blk: fix ZBD probe in kernels without ZBD support
On Mon, Mar 27, 2023 at 10:29:28PM -0400, Dmitry Fomichev wrote:> When the kernel is built without support for zoned block devices, > virtio-blk probe needs to error out any host-managed device scans > to prevent such devices from appearing in the system as non-zoned. > The current virtio-blk code simply bypasses all ZBD checks if > CONFIG_BLK_DEV_ZONED is not defined and this leads to host-managed > block devices being presented as non-zoned in the OS. This is one of > the main problems this patch series is aimed to fix. > > In this patch, make VIRTIO_BLK_F_ZONED feature defined even when > CONFIG_BLK_DEV_ZONED is not. This change makes the code compliant with > the voted revision of virtio-blk ZBD spec. Modify the probe code to > look at the situation when VIRTIO_BLK_F_ZONED is negotiated in a kernel > that is built without ZBD support. In this case, the code checks > the zoned model of the device and fails the probe is the device > is host-managed. > > The patch also adds the comment to clarify that the call to perform > the zoned device probe is correctly placed after virtio_device ready(). > > Fixes: 95bfec41bd3d ("virtio-blk: add support for zoned block devices") > Cc: stable at vger.kernel.org > Signed-off-by: Dmitry Fomichev <dmitry.fomichev at wdc.com> > --- > drivers/block/virtio_blk.c | 34 ++++++++++++++++++---------------- > 1 file changed, 18 insertions(+), 16 deletions(-)Reviewed-by: Stefan Hajnoczi <stefanha at redhat.com> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: not available URL: <http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20230328/2ac40f35/attachment.sig>