Michael S. Tsirkin
2023-Mar-23 12:47 UTC
[PATCH 1/1] vhost_task: Fix vhost_task_create return value
On Thu, Mar 23, 2023 at 12:50:49PM +0100, Christian Brauner wrote:> On Thu, Mar 23, 2023 at 07:43:04AM -0400, Michael S. Tsirkin wrote: > > On Thu, Mar 23, 2023 at 11:44:45AM +0100, Christian Brauner wrote: > > > On Thu, Mar 23, 2023 at 03:37:19AM -0400, Michael S. Tsirkin wrote: > > > > On Wed, Mar 22, 2023 at 01:56:05PM -0500, Mike Christie wrote: > > > > > vhost_task_create is supposed to return the vhost_task or NULL on > > > > > failure. This fixes it to return the correct value when the allocation > > > > > of the struct fails. > > > > > > > > > > Fixes: 77feab3c4156 ("vhost_task: Allow vhost layer to use copy_process") # mainline only > > > > > Reported-by: syzbot+6b27b2d2aba1c80cc13b at syzkaller.appspotmail.com > > > > > Signed-off-by: Mike Christie <michael.christie at oracle.com> > > > > > > > > Acked-by: Michael S. Tsirkin <mst at redhat.com> > > > > > > > > The affected patch is not upstream yet, right? > > > > I don't know if the tree in question allows rebases - linux-next > > > > does. So ideally it would be squashed to avoid issues during bisect. > > > > Still it's error path so I guess not a tragedy even without squashing. > > > > > > I tend to not rebase once stuff has been in linux-next but I make > > > exceptions as long as it's before -rc4. For now I've put the patch on > > > top (see the other mail I sent) but if it's really important I can > > > squash it after the weekend (I'll be mostly afk until then.). > > > > Hard to say how important, but I'd prefer that, yes. > > Ok, fold the fixup into > > e297cd54b3f8 vhost_task: Allow vhost layer to use copy_process > > the series is now at: > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git > branch: kernel.user_worker > > 1a5f8090c6de vhost: move worker thread fields to new struct > e297cd54b3f8 vhost_task: Allow vhost layer to use copy_process > 89c8e98d8cfb fork: allow kernel code to call copy_process > 094717586bf7 fork: Add kernel_clone_args flag to ignore signals > 11f3f500ec8a fork: add kernel_clone_args flag to not dup/clone files > 54e6842d0775 fork/vm: Move common PF_IO_WORKER behavior to new flag > c81cc5819faf kernel: Make io_thread and kthread bit fields > 73e0c116594d kthread: Pass in the thread's name during creation > cf587db2ee02 kernel: Allow a kernel thread's name to be set in copy_process > e0a98139c162 csky: Remove kernel_thread declarationThanks a lot! Mike could you give it a spin to make sure all is well? -- MST
Mike Christie
2023-Mar-23 15:40 UTC
[PATCH 1/1] vhost_task: Fix vhost_task_create return value
On 3/23/23 7:47 AM, Michael S. Tsirkin wrote:> On Thu, Mar 23, 2023 at 12:50:49PM +0100, Christian Brauner wrote: >> On Thu, Mar 23, 2023 at 07:43:04AM -0400, Michael S. Tsirkin wrote: >>> On Thu, Mar 23, 2023 at 11:44:45AM +0100, Christian Brauner wrote: >>>> On Thu, Mar 23, 2023 at 03:37:19AM -0400, Michael S. Tsirkin wrote: >>>>> On Wed, Mar 22, 2023 at 01:56:05PM -0500, Mike Christie wrote: >>>>>> vhost_task_create is supposed to return the vhost_task or NULL on >>>>>> failure. This fixes it to return the correct value when the allocation >>>>>> of the struct fails. >>>>>> >>>>>> Fixes: 77feab3c4156 ("vhost_task: Allow vhost layer to use copy_process") # mainline only >>>>>> Reported-by: syzbot+6b27b2d2aba1c80cc13b at syzkaller.appspotmail.com >>>>>> Signed-off-by: Mike Christie <michael.christie at oracle.com> >>>>> >>>>> Acked-by: Michael S. Tsirkin <mst at redhat.com> >>>>> >>>>> The affected patch is not upstream yet, right? >>>>> I don't know if the tree in question allows rebases - linux-next >>>>> does. So ideally it would be squashed to avoid issues during bisect. >>>>> Still it's error path so I guess not a tragedy even without squashing. >>>> >>>> I tend to not rebase once stuff has been in linux-next but I make >>>> exceptions as long as it's before -rc4. For now I've put the patch on >>>> top (see the other mail I sent) but if it's really important I can >>>> squash it after the weekend (I'll be mostly afk until then.). >>> >>> Hard to say how important, but I'd prefer that, yes. >> >> Ok, fold the fixup into >> >> e297cd54b3f8 vhost_task: Allow vhost layer to use copy_process >> >> the series is now at: >> >> tree: git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git >> branch: kernel.user_worker >> >> 1a5f8090c6de vhost: move worker thread fields to new struct >> e297cd54b3f8 vhost_task: Allow vhost layer to use copy_process >> 89c8e98d8cfb fork: allow kernel code to call copy_process >> 094717586bf7 fork: Add kernel_clone_args flag to ignore signals >> 11f3f500ec8a fork: add kernel_clone_args flag to not dup/clone files >> 54e6842d0775 fork/vm: Move common PF_IO_WORKER behavior to new flag >> c81cc5819faf kernel: Make io_thread and kthread bit fields >> 73e0c116594d kthread: Pass in the thread's name during creation >> cf587db2ee02 kernel: Allow a kernel thread's name to be set in copy_process >> e0a98139c162 csky: Remove kernel_thread declaration > > Thanks a lot! Mike could you give it a spin to make sure all is well?Yeah, I'll review and retest over the weekend. If I hit any issues I'll let you guys know by monday.
Mike Christie
2023-Mar-25 22:45 UTC
[PATCH 1/1] vhost_task: Fix vhost_task_create return value
On 3/23/23 7:47 AM, Michael S. Tsirkin wrote:> On Thu, Mar 23, 2023 at 12:50:49PM +0100, Christian Brauner wrote: >> On Thu, Mar 23, 2023 at 07:43:04AM -0400, Michael S. Tsirkin wrote: >>> On Thu, Mar 23, 2023 at 11:44:45AM +0100, Christian Brauner wrote: >>>> On Thu, Mar 23, 2023 at 03:37:19AM -0400, Michael S. Tsirkin wrote: >>>>> On Wed, Mar 22, 2023 at 01:56:05PM -0500, Mike Christie wrote: >>>>>> vhost_task_create is supposed to return the vhost_task or NULL on >>>>>> failure. This fixes it to return the correct value when the allocation >>>>>> of the struct fails. >>>>>> >>>>>> Fixes: 77feab3c4156 ("vhost_task: Allow vhost layer to use copy_process") # mainline only >>>>>> Reported-by: syzbot+6b27b2d2aba1c80cc13b at syzkaller.appspotmail.com >>>>>> Signed-off-by: Mike Christie <michael.christie at oracle.com> >>>>> >>>>> Acked-by: Michael S. Tsirkin <mst at redhat.com> >>>>> >>>>> The affected patch is not upstream yet, right? >>>>> I don't know if the tree in question allows rebases - linux-next >>>>> does. So ideally it would be squashed to avoid issues during bisect. >>>>> Still it's error path so I guess not a tragedy even without squashing. >>>> >>>> I tend to not rebase once stuff has been in linux-next but I make >>>> exceptions as long as it's before -rc4. For now I've put the patch on >>>> top (see the other mail I sent) but if it's really important I can >>>> squash it after the weekend (I'll be mostly afk until then.). >>> >>> Hard to say how important, but I'd prefer that, yes. >> >> Ok, fold the fixup into >> >> e297cd54b3f8 vhost_task: Allow vhost layer to use copy_process >> >> the series is now at: >> >> tree: git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git >> branch: kernel.user_worker >> >> 1a5f8090c6de vhost: move worker thread fields to new struct >> e297cd54b3f8 vhost_task: Allow vhost layer to use copy_process >> 89c8e98d8cfb fork: allow kernel code to call copy_process >> 094717586bf7 fork: Add kernel_clone_args flag to ignore signals >> 11f3f500ec8a fork: add kernel_clone_args flag to not dup/clone files >> 54e6842d0775 fork/vm: Move common PF_IO_WORKER behavior to new flag >> c81cc5819faf kernel: Make io_thread and kthread bit fields >> 73e0c116594d kthread: Pass in the thread's name during creation >> cf587db2ee02 kernel: Allow a kernel thread's name to be set in copy_process >> e0a98139c162 csky: Remove kernel_thread declaration > > Thanks a lot! Mike could you give it a spin to make sure all is well?Reviewed and tested the patches and it's all ok.
Possibly Parallel Threads
- [PATCH 1/1] vhost_task: Fix vhost_task_create return value
- [PATCH v11 8/8] vhost: use vhost_tasks for worker threads
- [PATCH 0/3] vhost: Fix freezer/ps regressions
- [PATCH 1/1] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
- [PATCH 1/1] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression