Thomas Zimmermann
2023-Mar-16 09:38 UTC
[PATCH 2/6] drm/fbdev-generic: Remove unused prefer_shadow_fbdev flag
Hi Am 16.03.23 um 03:16 schrieb Zack Rusin:> On Wed, 2023-03-15 at 17:14 +0100, Thomas Zimmermann wrote: >> Remove the flag prefer_shadow_fbdev from struct drm_mode_config. >> Drivers set this flag to enable shadow buffering in the generic >> fbdev emulation. Such shadow buffering is now mandatory, so the >> flag is unused. >> >> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de> >> --- >> ?drivers/gpu/drm/tiny/bochs.c??????? | 1 - >> ?drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 1 - >> ?include/drm/drm_mode_config.h?????? | 7 ------- >> ?3 files changed, 9 deletions(-) >> >> diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c >> index 024346054c70..d254679a136e 100644 >> --- a/drivers/gpu/drm/tiny/bochs.c >> +++ b/drivers/gpu/drm/tiny/bochs.c >> @@ -545,7 +545,6 @@ static int bochs_kms_init(struct bochs_device *bochs) >> >> ????????bochs->dev->mode_config.preferred_depth = 24; >> ????????bochs->dev->mode_config.prefer_shadow = 0; >> -???????bochs->dev->mode_config.prefer_shadow_fbdev = 1; >> ????????bochs->dev->mode_config.quirk_addfb_prefer_host_byte_order = true; >> >> ????????bochs->dev->mode_config.funcs = &bochs_mode_funcs; >> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c >> b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c >> index 84d6380b9895..5162a7a12792 100644 >> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c >> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c >> @@ -2112,7 +2112,6 @@ int vmw_kms_init(struct vmw_private *dev_priv) >> ????????dev->mode_config.max_width = dev_priv->texture_max_width; >> ????????dev->mode_config.max_height = dev_priv->texture_max_height; >> ????????dev->mode_config.preferred_depth = dev_priv->assume_16bpp ? 16 : 32; >> -???????dev->mode_config.prefer_shadow_fbdev = !dev_priv->has_mob; >> >> ????????drm_mode_create_suggested_offset_properties(dev); >> ????????vmw_kms_create_hotplug_mode_update_property(dev_priv); >> diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h >> index e5b053001d22..973119a9176b 100644 >> --- a/include/drm/drm_mode_config.h >> +++ b/include/drm/drm_mode_config.h >> @@ -890,13 +890,6 @@ struct drm_mode_config { >> ????????/* dumb ioctl parameters */ >> ????????uint32_t preferred_depth, prefer_shadow; >> >> -???????/** >> -??????? * @prefer_shadow_fbdev: >> -??????? * >> -??????? * Hint to framebuffer emulation to prefer shadow-fb rendering. >> -??????? */ >> -???????bool prefer_shadow_fbdev; >> - >> ????????/** >> ???????? * @quirk_addfb_prefer_xbgr_30bpp: >> ???????? * > > For this one: > Reviewed-by: Zack Rusin <zackr at vmware.com> > > The entire series looks great. I think it's a great cleanup: > Acked-by: Zack Rusin <zackr at vmware.com> > For the rest.Thanks a lot!> > z >-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N?rnberg, Germany (HRB 36809, AG N?rnberg) Gesch?ftsf?hrer: Ivo Totev -------------- next part -------------- A non-text attachment was scrubbed... Name: OpenPGP_signature Type: application/pgp-signature Size: 840 bytes Desc: OpenPGP digital signature URL: <http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20230316/fb892d3f/attachment.sig>