Michael S. Tsirkin
2023-Mar-14 03:43 UTC
[PATCH 1/2] vdpa/mlx5: Make VIRTIO_NET_F_MRG_RXBUF off by default
On Tue, Mar 14, 2023 at 02:07:02AM +0000, Parav Pandit wrote:> > > > From: Michael S. Tsirkin <mst at redhat.com> > > Sent: Monday, March 13, 2023 5:45 PM > > > On Mon, Mar 13, 2023 at 09:34:50PM +0000, Parav Pandit wrote: > > > > > > > > > > From: Michael S. Tsirkin <mst at redhat.com> > > > > Sent: Monday, March 13, 2023 5:24 PM I mean if this is claiming to > > > > fix a performance regression it should have a Fixes: > > > > tag with the commit that introduced the regression. > > > > > > The fixes tag should be, > > > > > > Fixes: deeacf35c922d ("vdpa/mlx5: support device features > > > provisioning") > > > > > > Eli, > > > Please add. > > > > Hmm okay so to make sure, before this commit device by default is created > > without mrg buffers? With the commit it's created with and what the change > > does it revert the default back to what it was? > > Yes.So IIUC currently default comes from device. Which makes sense at some level, we can say device knows best maybe? However in this case, we decided to override the default because changing this improves some things and regresses others. Which is ok at some level but then how does user know what are the device defaults? -- MST