Stefano Garzarella
2023-Mar-09 16:29 UTC
[RFC PATCH v3 2/4] virtio/vsock: remove redundant 'skb_pull()' call
On Thu, Mar 09, 2023 at 01:12:42PM +0300, Arseniy Krasnov wrote: I would add: Since we now no longer use `skb->len` to update credit, ...>There is no sense to update skbuff state, because it is used only once >after dequeue to copy data and then will be released. > >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >--- > net/vmw_vsock/virtio_transport_common.c | 1 - > 1 file changed, 1 deletion(-)The patch LGTM! Stefano> >diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c >index 618680fd9906..9a411475e201 100644 >--- a/net/vmw_vsock/virtio_transport_common.c >+++ b/net/vmw_vsock/virtio_transport_common.c >@@ -465,7 +465,6 @@ static int virtio_transport_seqpacket_do_dequeue(struct vsock_sock *vsk, > dequeued_len = err; > } else { > user_buf_len -= bytes_to_copy; >- skb_pull(skb, bytes_to_copy); > } > > spin_lock_bh(&vvs->rx_lock); >-- >2.25.1 >