Linux Virtualization - Oct 2021 - [PATCH linux-next v4 2/8] vdpa: Introduce query of device config layout

? 2021/10/22 ??12:35, Parav Pandit ??:
> Introduce a command to query a device config layout.
>
> An example query of network vdpa device:
>
> $ vdpa dev add name bar mgmtdev vdpasim_net
>
> $ vdpa dev config show
> bar: mac 00:35:09:19:48:05 link up link_announce false mtu 1500

Nit: it looks to me this patch doesn't expose link_announce but 
max_virtqueue_pairs.

Other looks good.

Thanks

>
> $ vdpa dev config show -jp
> {
>      "config": {
>          "bar": {
>              "mac": "00:35:09:19:48:05",
>              "link ": "up",
>              "link_announce ": false,
>              "mtu": 1500,
>          }
>      }
> }
>
> Signed-off-by: Parav Pandit<parav at nvidia.com>
> Signed-off-by: Eli Cohen<elic at nvidia.com>
>
> ---
> changelog:
> v3->v4:
>   - removed config space fields reporting which are not used by mlx5
>     and sim drivers

> From: Jason Wang <jasowang at redhat.com>
> Sent: Monday, October 25, 2021 11:36 AM
> 
> 
> ? 2021/10/22 ??12:35, Parav Pandit ??:
> > Introduce a command to query a device config layout.
> >
> > An example query of network vdpa device:
> >
> > $ vdpa dev add name bar mgmtdev vdpasim_net
> >
> > $ vdpa dev config show
> > bar: mac 00:35:09:19:48:05 link up link_announce false mtu 1500
> 
> 
> Nit: it looks to me this patch doesn't expose link_announce but
> max_virtqueue_pairs.
It does expose the net status field that contains the link_announce.
I missed to update the example for including
max_vq_pairs.
> 
> Other looks good.
> 
> Thanks

> From: Jason Wang <jasowang at redhat.com>
> Sent: Monday, October 25, 2021 11:36 AM
> 
> ? 2021/10/22 ??12:35, Parav Pandit ??:
> > Introduce a command to query a device config layout.
> >
> > An example query of network vdpa device:
> >
> > $ vdpa dev add name bar mgmtdev vdpasim_net
> >
> > $ vdpa dev config show
> > bar: mac 00:35:09:19:48:05 link up link_announce false mtu 1500
> 
> 
> Nit: it looks to me this patch doesn't expose link_announce but
> max_virtqueue_pairs.
> 
> Other looks good.
I recollect now when started working on v5.
Above commit log example is correct. Max_virtqueue_pairs is not exposed for the
vdpa device as this field in the config space is not valid.
It is not valid because this vdpa net device is single queue.
So this commit log is accurate.