Vivek Goyal
2021-Sep-07 18:10 UTC
[PATCH 2/2] virtiofs: reduce lock contention on fpq->lock
On Tue, Sep 07, 2021 at 10:57:07AM +0200, Miklos Szeredi wrote:> On Thu, 12 Aug 2021 at 07:46, Jeffle Xu <jefflexu at linux.alibaba.com> wrote: > > > > From: Liu Bo <bo.liu at linux.alibaba.com> > > > > Since %req has been removed from fpq->processing_list, no one except > > request_wait_answer() is looking at this %req and request_wait_answer() > > waits only on FINISH flag, it's OK to remove fpq->lock after %req is > > dropped from the list. > > I'll accept a patch to remove FR_SENT completely from virtiofs. >Recently I was also looking at FR_SENT flag and was wondering if it is atomic bit flag, then why do we need to take spin lock around it. Probably we need just some barrier if code needs it but not necessarily any lock. But I agree that FR_SENT seems not usable from virtiofs point of view as we don't have support for interrupt request.> This flag is used for queuing interrupts but interrupts are not yet > implemented in virtiofs. When blocking lock support is added the > interrupt handling needs to be properly designed.Hmm.., I did not think about this. I was getting ready to post patches for blocking posix locks but it does not have any support for interrupting the locking request (either blocked or queued). Is implementing interrupt support a requirement for getting blocking posix lock patches in? Thanks Vivek