Wei Yongjun
2021-May-19 14:16 UTC
[PATCH -next] vp_vdpa: fix error return code in vp_vdpa_probe()
Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 11d8ffed00b2 ("vp_vdpa: switch to use
vp_modern_map_vq_notify()")
Reported-by: Hulk Robot <hulkci at huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1 at huawei.com>
---
drivers/vdpa/virtio_pci/vp_vdpa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c
b/drivers/vdpa/virtio_pci/vp_vdpa.c
index c76ebb531212..e5d92db728d3 100644
--- a/drivers/vdpa/virtio_pci/vp_vdpa.c
+++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct
pci_device_id *id)
vp_modern_map_vq_notify(mdev, i,
&vp_vdpa->vring[i].notify_pa);
if (!vp_vdpa->vring[i].notify) {
+ ret = -ENOMEM;
dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
goto err;
}
Stefano Garzarella
2021-May-20 07:05 UTC
[PATCH -next] vp_vdpa: fix error return code in vp_vdpa_probe()
On Wed, May 19, 2021 at 02:16:46PM +0000, Wei Yongjun wrote:>Fix to return negative error code -ENOMEM from the error handling >case instead of 0, as done elsewhere in this function. > >Fixes: 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()") >Reported-by: Hulk Robot <hulkci at huawei.com> >Signed-off-by: Wei Yongjun <weiyongjun1 at huawei.com> >--- > drivers/vdpa/virtio_pci/vp_vdpa.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c >index c76ebb531212..e5d92db728d3 100644 >--- a/drivers/vdpa/virtio_pci/vp_vdpa.c >+++ b/drivers/vdpa/virtio_pci/vp_vdpa.c >@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id) > vp_modern_map_vq_notify(mdev, i, > &vp_vdpa->vring[i].notify_pa); > if (!vp_vdpa->vring[i].notify) { >+ ret = -ENOMEM; > dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i); > goto err; > } >Reviewed-by: Stefano Garzarella <sgarzare at redhat.com>