Christoph Hellwig
2021-May-05 05:43 UTC
[PATCH] Provide detailed specification of virtio-blk lifetime metrics
On Tue, Apr 20, 2021 at 04:25:56PM +0000, Enrico Granata wrote:> In the course of review, some concerns were surfaced about the > original virtio-blk lifetime proposal, as it depends on the eMMC > spec which is not open > > Add a more detailed description of the meaning of the fields > added by that proposal to the virtio-blk specification, as to > make it feasible to understand and implement the new lifetime > metrics feature without needing to refer to JEDEC's specification > > This patch does not change the meaning of those fields nor add > any new fields, but it is intended to provide an open and more > clear description of the meaning associated with those fields. > > Signed-off-by: Enrico Granata <egranata at google.com>Still not a fan of the encoding, but at least it is properly documented now: Acked-by: Christoph Hellwig <hch at lst.de>
Michael S. Tsirkin
2021-May-05 20:10 UTC
[PATCH] Provide detailed specification of virtio-blk lifetime metrics
On Wed, May 05, 2021 at 06:43:14AM +0100, Christoph Hellwig wrote:> On Tue, Apr 20, 2021 at 04:25:56PM +0000, Enrico Granata wrote: > > In the course of review, some concerns were surfaced about the > > original virtio-blk lifetime proposal, as it depends on the eMMC > > spec which is not open > > > > Add a more detailed description of the meaning of the fields > > added by that proposal to the virtio-blk specification, as to > > make it feasible to understand and implement the new lifetime > > metrics feature without needing to refer to JEDEC's specification > > > > This patch does not change the meaning of those fields nor add > > any new fields, but it is intended to provide an open and more > > clear description of the meaning associated with those fields. > > > > Signed-off-by: Enrico Granata <egranata at google.com> > > Still not a fan of the encoding, but at least it is properly documented > now: > > Acked-by: Christoph Hellwig <hch at lst.de>With that, would you like to ack the virtip-blk patch too? The format didn't actually change ... -- MST