Linux Virtualization - Jul 2020 - sparse warnings in net/vmw_vsock/virtio_transport.c

RCU trickery:

net/vmw_vsock/virtio_transport.c:73:17: error: incompatible types in comparison
expression (different address spaces):
net/vmw_vsock/virtio_transport.c:73:17:    struct virtio_vsock [noderef] __rcu *
net/vmw_vsock/virtio_transport.c:73:17:    struct virtio_vsock *
net/vmw_vsock/virtio_transport.c:171:17: error: incompatible types in comparison
expression (different address spaces):
net/vmw_vsock/virtio_transport.c:171:17:    struct virtio_vsock [noderef] __rcu
*
net/vmw_vsock/virtio_transport.c:171:17:    struct virtio_vsock *
net/vmw_vsock/virtio_transport.c:207:17: error: incompatible types in comparison
expression (different address spaces):
net/vmw_vsock/virtio_transport.c:207:17:    struct virtio_vsock [noderef] __rcu
*
net/vmw_vsock/virtio_transport.c:207:17:    struct virtio_vsock *
net/vmw_vsock/virtio_transport.c:561:13: error: incompatible types in comparison
expression (different address spaces):
net/vmw_vsock/virtio_transport.c:561:13:    struct virtio_vsock [noderef] __rcu
*
net/vmw_vsock/virtio_transport.c:561:13:    struct virtio_vsock *
net/vmw_vsock/virtio_transport.c:612:9: error: incompatible types in comparison
expression (different address spaces):
net/vmw_vsock/virtio_transport.c:612:9:    struct virtio_vsock [noderef] __rcu *
net/vmw_vsock/virtio_transport.c:612:9:    struct virtio_vsock *
net/vmw_vsock/virtio_transport.c:631:9: error: incompatible types in comparison
expression (different address spaces):
net/vmw_vsock/virtio_transport.c:631:9:    struct virtio_vsock [noderef] __rcu *
net/vmw_vsock/virtio_transport.c:631:9:    struct virtio_vsock *
  CC [M]  net/vmw_vsock/virtio_transport.o

can you take a look at fixing this pls?

-- 
MST

On Fri, Jul 10, 2020 at 06:24:51AM -0400, Michael S. Tsirkin
wrote:
> RCU trickery:
> 
> net/vmw_vsock/virtio_transport.c:73:17: error: incompatible types in
comparison expression (different address spaces):
> net/vmw_vsock/virtio_transport.c:73:17:    struct virtio_vsock [noderef]
__rcu *
> net/vmw_vsock/virtio_transport.c:73:17:    struct virtio_vsock *
> net/vmw_vsock/virtio_transport.c:171:17: error: incompatible types in
comparison expression (different address spaces):
> net/vmw_vsock/virtio_transport.c:171:17:    struct virtio_vsock [noderef]
__rcu *
> net/vmw_vsock/virtio_transport.c:171:17:    struct virtio_vsock *
> net/vmw_vsock/virtio_transport.c:207:17: error: incompatible types in
comparison expression (different address spaces):
> net/vmw_vsock/virtio_transport.c:207:17:    struct virtio_vsock [noderef]
__rcu *
> net/vmw_vsock/virtio_transport.c:207:17:    struct virtio_vsock *
> net/vmw_vsock/virtio_transport.c:561:13: error: incompatible types in
comparison expression (different address spaces):
> net/vmw_vsock/virtio_transport.c:561:13:    struct virtio_vsock [noderef]
__rcu *
> net/vmw_vsock/virtio_transport.c:561:13:    struct virtio_vsock *
> net/vmw_vsock/virtio_transport.c:612:9: error: incompatible types in
comparison expression (different address spaces):
> net/vmw_vsock/virtio_transport.c:612:9:    struct virtio_vsock [noderef]
__rcu *
> net/vmw_vsock/virtio_transport.c:612:9:    struct virtio_vsock *
> net/vmw_vsock/virtio_transport.c:631:9: error: incompatible types in
comparison expression (different address spaces):
> net/vmw_vsock/virtio_transport.c:631:9:    struct virtio_vsock [noderef]
__rcu *
> net/vmw_vsock/virtio_transport.c:631:9:    struct virtio_vsock *
>   CC [M]  net/vmw_vsock/virtio_transport.o
> 
> can you take a look at fixing this pls?
Thanks for reporting!

We should annotate 'the_virtio_vsock' with __rcu.

I'll send a patch to fix these warnings.

Thanks,
Stefano