Gerd Hoffmann
2019-Jun-27 12:23 UTC
[PATCH v3 3/5] drm/bochs: drop yres_virtual from struct bochs_device
Not needed, writing to VBE_DISPI_INDEX_VIRT_HEIGHT has no effect anyway. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/gpu/drm/bochs/bochs.h | 1 - drivers/gpu/drm/bochs/bochs_hw.c | 8 ++------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs.h b/drivers/gpu/drm/bochs/bochs.h index 246f05f4a711..5c90b76708ef 100644 --- a/drivers/gpu/drm/bochs/bochs.h +++ b/drivers/gpu/drm/bochs/bochs.h @@ -64,7 +64,6 @@ struct bochs_device { /* mode */ u16 xres; u16 yres; - u16 yres_virtual; u32 stride; u32 bpp; struct edid *edid; diff --git a/drivers/gpu/drm/bochs/bochs_hw.c b/drivers/gpu/drm/bochs/bochs_hw.c index 67101c85029c..9ab6ec269ef9 100644 --- a/drivers/gpu/drm/bochs/bochs_hw.c +++ b/drivers/gpu/drm/bochs/bochs_hw.c @@ -207,11 +207,9 @@ void bochs_hw_setmode(struct bochs_device *bochs, bochs->yres = mode->vdisplay; bochs->bpp = 32; bochs->stride = mode->hdisplay * (bochs->bpp / 8); - bochs->yres_virtual = bochs->fb_size / bochs->stride; - DRM_DEBUG_DRIVER("%dx%d @ %d bpp, vy %d\n", - bochs->xres, bochs->yres, bochs->bpp, - bochs->yres_virtual); + DRM_DEBUG_DRIVER("%dx%d @ %d bpp\n", + bochs->xres, bochs->yres, bochs->bpp); bochs_vga_writeb(bochs, 0x3c0, 0x20); /* unblank */ @@ -221,8 +219,6 @@ void bochs_hw_setmode(struct bochs_device *bochs, bochs_dispi_write(bochs, VBE_DISPI_INDEX_YRES, bochs->yres); bochs_dispi_write(bochs, VBE_DISPI_INDEX_BANK, 0); bochs_dispi_write(bochs, VBE_DISPI_INDEX_VIRT_WIDTH, bochs->xres); - bochs_dispi_write(bochs, VBE_DISPI_INDEX_VIRT_HEIGHT, - bochs->yres_virtual); bochs_dispi_write(bochs, VBE_DISPI_INDEX_X_OFFSET, 0); bochs_dispi_write(bochs, VBE_DISPI_INDEX_Y_OFFSET, 0); -- 2.18.1
Apparently Analagous Threads
- [PATCH v3 4/5] drm/bochs: drop stride and bpp from struct bochs_device
- [PATCH v3 4/5] drm/bochs: support changing byteorder at mode set time
- [PATCH 02/14] drm/bochs: split bochs_hw_setmode
- [PATCH v3 2/5] drm/bochs: pass framebuffer to bochs_hw_setbase
- [PATCH v2 2/2] drm/bochs: add edid support.