Linux Virtualization - May 2019 - [Qemu-devel] [PATCH v7 4/6] dax: check synchronous mapping is supported

From: Pankaj Gupta <pagupta at redhat.com>
Date: Thu, Apr 25, 2019 at 10:00 PM
> +static inline bool daxdev_mapping_supported(struct vm_area_struct *vma,
> +                               struct dax_device *dax_dev)
> +{
> +       return !(vma->flags & VM_SYNC);
> +}
Shouldn't it be rather `return !(vma->vm_flags & VM_SYNC);`? There is
no field named `flags` in `struct vm_area_struct`.

Thank you,
Jakub

> 
> From: Pankaj Gupta <pagupta at redhat.com>
> Date: Thu, Apr 25, 2019 at 10:00 PM
> 
> > +static inline bool daxdev_mapping_supported(struct vm_area_struct
*vma,
> > +                               struct dax_device *dax_dev)
> > +{
> > +       return !(vma->flags & VM_SYNC);
> > +}
> 
> Shouldn't it be rather `return !(vma->vm_flags & VM_SYNC);`?
There is
> no field named `flags` in `struct vm_area_struct`.
Thanks for catching. Sorry! for this. 

Will correct in v8.

Thank you,
Pankaj 
> 
> Thank you,
> Jakub
>