On Fri, 12 Apr 2019, Halil Pasic wrote:> On Fri, 12 Apr 2019 14:12:31 +0200 (CEST)
> Sebastian Ott <sebott at linux.ibm.com> wrote:
> > On Fri, 12 Apr 2019, Halil Pasic wrote:
> > > On Thu, 11 Apr 2019 20:25:01 +0200 (CEST)
> > > Sebastian Ott <sebott at linux.ibm.com> wrote:
> > > > I don't think we should use this global DMA pool. I
guess it's OK for
> > > > stuff like airq (where we don't have a struct device at
hand) but for
> > > > CCW we should use the device we have. Yes, this way we waste
some memory
> > > > but all dma memory a device uses should fit in a page - so
the wastage
> > > > is not too much.
>
> Regarding the wastage. Let us do the math together in search for an
> upper (wastage) limit.
[...]> Currently we need at least 224 bytes per device that is ~ 6%
> of a PAGE_SIZE.
Yes, we basically waste the whole page. I'm ok with that if the benefit is
to play nice with the kernel APIs.
> > For practical
> > matters: DMA debugging will complain about misuse of a specific device
or
> > driver.
> >
>
> Do you mean CONFIG_DMA_API_DEBUG and CONFIG_DMA_API_DEBUG_SG? I've been
> running with those and did not see any complaints. Maybe we should
> clarify this one offline...
I didn't mean to imply that there are bugs already - just that when used
as intended the DMA_DEBUG_API can complain about stuff like "your device
is gone but you have still DMA memory set up for it" which will not work
if you don't use the correct device...
Sebastian
