Linux Virtualization - Jan 2018 - Ping Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all

No need to get into the submenu to disable all VIRTIO-related
config entries.

This makes it easier to disable all VIRTIO config options
without entering the submenu. It will also enable one
to see that en/dis-abled state from the outside menu.

This is only intended to change menuconfig UI, not change
the config dependencies.

v2: Added "default y" to avoid breaking existing configs
v3: Fixed wrong indentation, added *-by from Randy

Signed-off-by: Vincent Legoll <vincent.legoll at gmail.com>
Reviewed-by: Randy Dunlap <rdunlap at infradead.org>
Tested-by: Randy Dunlap <rdunlap at infradead.org> # works for me
---
 drivers/virtio/Kconfig | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index cff773f15b7e..35897649c24f 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -5,7 +5,11 @@ config VIRTIO
 	  bus, such as CONFIG_VIRTIO_PCI, CONFIG_VIRTIO_MMIO, CONFIG_RPMSG
 	  or CONFIG_S390_GUEST.
 
-menu "Virtio drivers"
+menuconfig VIRTIO_MENU
+	bool "Virtio drivers"
+	default y
+
+if VIRTIO_MENU
 
 config VIRTIO_PCI
 	tristate "PCI driver for virtio devices"
@@ -79,4 +83,4 @@ config VIRTIO_MMIO_CMDLINE_DEVICES
 
 	 If unsure, say 'N'.
 
-endmenu
+endif # VIRTIO_MENU
-- 
2.14.1

Vincent Legoll <vincent.legoll at gmail.com> writes:
> No need to get into the submenu to disable all VIRTIO-related
> config entries.
>
> This makes it easier to disable all VIRTIO config options
> without entering the submenu. It will also enable one
> to see that en/dis-abled state from the outside menu.
>
> This is only intended to change menuconfig UI, not change
> the config dependencies.
>
> v2: Added "default y" to avoid breaking existing configs
> v3: Fixed wrong indentation, added *-by from Randy
>
> Signed-off-by: Vincent Legoll <vincent.legoll at gmail.com>
> Reviewed-by: Randy Dunlap <rdunlap at infradead.org>
> Tested-by: Randy Dunlap <rdunlap at infradead.org> # works for me
> ---
>  drivers/virtio/Kconfig | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
This has been broken in linux-next for ~6 weeks now, can we please merge
this and get it fixed.

cheers

On 1/23/18, Michael Ellerman <mpe at ellerman.id.au>
wrote:
> This has been broken in linux-next for ~6 weeks now, can we please merge
> this and get it fixed.
Added Stephen Rothwell to cc

-- 
Vincent Legoll