Felipe Franciosi
2016-Nov-14 14:16 UTC
[PATCH] virtio_ring: fix description of virtqueue_get_buf
The device (not the driver) populates the used ring and includes the len of how much data was written. Signed-off-by: Felipe Franciosi <felipe at nutanix.com> --- drivers/virtio/virtio_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 489bfc6..8a0d6a9 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -649,7 +649,7 @@ static inline bool more_used(const struct vring_virtqueue *vq) * @vq: the struct virtqueue we're talking about. * @len: the length written into the buffer * - * If the driver wrote data into the buffer, @len will be set to the + * If the device wrote data into the buffer, @len will be set to the * amount written. This means you don't need to clear the buffer * beforehand to ensure there's no data leakage in the case of short * writes. -- 1.9.4
Jason Wang
2016-Nov-15 03:21 UTC
[PATCH] virtio_ring: fix description of virtqueue_get_buf
On 2016?11?14? 22:16, Felipe Franciosi wrote:> The device (not the driver) populates the used ring and includes the len > of how much data was written. > > Signed-off-by: Felipe Franciosi <felipe at nutanix.com> > --- > drivers/virtio/virtio_ring.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index 489bfc6..8a0d6a9 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -649,7 +649,7 @@ static inline bool more_used(const struct vring_virtqueue *vq) > * @vq: the struct virtqueue we're talking about. > * @len: the length written into the buffer > * > - * If the driver wrote data into the buffer, @len will be set to the > + * If the device wrote data into the buffer, @len will be set to the > * amount written. This means you don't need to clear the buffer > * beforehand to ensure there's no data leakage in the case of short > * writes.Reviewed-by: Jason Wang <jasowang at redhat.com>
Seemingly Similar Threads
- [PATCH] virtio_ring: fix description of virtqueue_get_buf
- [PATCH] Rescan the entire target on transport reset when LUN is 0
- [PATCH] Rescan the entire target on transport reset when LUN is 0
- [PATCH] Rescan the entire target on transport reset when LUN is 0
- [PATCH] Rescan the entire target on transport reset when LUN is 0