From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
Fixes the following sparse warning:
drivers/gpu/drm/virtio/virtgpu_display.c:349:37: warning:
symbol 'virtio_mode_config_helpers' was not declared. Should it be
static?
Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
---
drivers/gpu/drm/virtio/virtgpu_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c
b/drivers/gpu/drm/virtio/virtgpu_display.c
index fdfc711..4e192aa 100644
--- a/drivers/gpu/drm/virtio/virtgpu_display.c
+++ b/drivers/gpu/drm/virtio/virtgpu_display.c
@@ -346,7 +346,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state
*state)
drm_atomic_helper_cleanup_planes(dev, state);
}
-struct drm_mode_config_helper_funcs virtio_mode_config_helpers = {
+static struct drm_mode_config_helper_funcs virtio_mode_config_helpers = {
.atomic_commit_tail = vgdev_atomic_commit_tail,
};
On Tue, Jul 19, 2016 at 8:45 AM, Wei Yongjun <weiyj_lk at 163.com> wrote:> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn> > > Fixes the following sparse warning: > > drivers/gpu/drm/virtio/virtgpu_display.c:349:37: warning: > symbol 'virtio_mode_config_helpers' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>Applied to drm-misc> --- > drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c > index fdfc711..4e192aa 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_display.c > +++ b/drivers/gpu/drm/virtio/virtgpu_display.c > @@ -346,7 +346,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state) > drm_atomic_helper_cleanup_planes(dev, state); > } > > -struct drm_mode_config_helper_funcs virtio_mode_config_helpers = { > +static struct drm_mode_config_helper_funcs virtio_mode_config_helpers = { > .atomic_commit_tail = vgdev_atomic_commit_tail, > }; > >
Possibly Parallel Threads
- [PATCH -next] drm/virtio: Fix non static symbol warning
- [PATCH 2/2] drm/virtio: Remove open-coded commit-tail function
- [PATCH 2/2] drm/virtio: Remove open-coded commit-tail function
- [PATCH 2/2] drm/virtio: Remove open-coded commit-tail function
- [PATCH -next] virtio_console: make local symbols static