Linux Virtualization - Jun 2016 - [PATCH v3] tools/virtio/ringtest: fix run-on-all.sh to work without /dev/cpu

/dev/cpu is only available on x86 with certain modules (e.g. msr) enabled.
Using lscpu to get processors count is more portable.

Signed-off-by: Mike Rapoport <rppt at linux.vnet.ibm.com>
---
v3: simplify by using lscpu -p=cpu 
v2: use lspcu instead of /proc/cpuinfo as per Cornelia's suggestion

 tools/virtio/ringtest/run-on-all.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/virtio/ringtest/run-on-all.sh
b/tools/virtio/ringtest/run-on-all.sh
index 52b0f71..2e69ca8 100755
--- a/tools/virtio/ringtest/run-on-all.sh
+++ b/tools/virtio/ringtest/run-on-all.sh
@@ -3,10 +3,10 @@
 #use last CPU for host. Why not the first?
 #many devices tend to use cpu0 by default so
 #it tends to be busier
-HOST_AFFINITY=$(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n|tail -1)
+HOST_AFFINITY=$(lscpu -p=cpu | tail -1)
 
 #run command on all cpus
-for cpu in $(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n);
+for cpu in $(seq 0 $HOST_AFFINITY)
 do
 	#Don't run guest and host on same CPU
 	#It actually works ok if using signalling
-- 
1.9.1

On Wed,  4 May 2016 13:15:50 +0300
Mike Rapoport <rppt at linux.vnet.ibm.com> wrote:
> /dev/cpu is only available on x86 with certain modules (e.g. msr) enabled.
> Using lscpu to get processors count is more portable.
> 
> Signed-off-by: Mike Rapoport <rppt at linux.vnet.ibm.com>
> ---
> v3: simplify by using lscpu -p=cpu 
> v2: use lspcu instead of /proc/cpuinfo as per Cornelia's suggestion
> 
>  tools/virtio/ringtest/run-on-all.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/virtio/ringtest/run-on-all.sh
b/tools/virtio/ringtest/run-on-all.sh
> index 52b0f71..2e69ca8 100755
> --- a/tools/virtio/ringtest/run-on-all.sh
> +++ b/tools/virtio/ringtest/run-on-all.sh
> @@ -3,10 +3,10 @@
>  #use last CPU for host. Why not the first?
>  #many devices tend to use cpu0 by default so
>  #it tends to be busier
> -HOST_AFFINITY=$(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n|tail -1)
> +HOST_AFFINITY=$(lscpu -p=cpu | tail -1)
> 
>  #run command on all cpus
> -for cpu in $(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n);
> +for cpu in $(seq 0 $HOST_AFFINITY)
>  do
>  	#Don't run guest and host on same CPU
>  	#It actually works ok if using signalling
I think it's fine to depend on lscpu for such a test tool.

Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com>

Michael,

Any updates on this?

On Wed, May 04, 2016 at 01:15:50PM +0300, Mike Rapoport
wrote:
> /dev/cpu is only available on x86 with certain modules (e.g. msr) enabled.
> Using lscpu to get processors count is more portable.
> 
> Signed-off-by: Mike Rapoport <rppt at linux.vnet.ibm.com>
> ---
> v3: simplify by using lscpu -p=cpu 
> v2: use lspcu instead of /proc/cpuinfo as per Cornelia's suggestion
> 
>  tools/virtio/ringtest/run-on-all.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/virtio/ringtest/run-on-all.sh
b/tools/virtio/ringtest/run-on-all.sh
> index 52b0f71..2e69ca8 100755
> --- a/tools/virtio/ringtest/run-on-all.sh
> +++ b/tools/virtio/ringtest/run-on-all.sh
> @@ -3,10 +3,10 @@
>  #use last CPU for host. Why not the first?
>  #many devices tend to use cpu0 by default so
>  #it tends to be busier
> -HOST_AFFINITY=$(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n|tail -1)
> +HOST_AFFINITY=$(lscpu -p=cpu | tail -1)
> 
>  #run command on all cpus
> -for cpu in $(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n);
> +for cpu in $(seq 0 $HOST_AFFINITY)
>  do
>  	#Don't run guest and host on same CPU
>  	#It actually works ok if using signalling
> -- 
> 1.9.1
>

Ping?

On Tue, May 24, 2016 at 03:41:33PM +0300, Mike Rapoport
wrote:
> Michael,
> 
> Any updates on this?
> 
> On Wed, May 04, 2016 at 01:15:50PM +0300, Mike Rapoport wrote:
> > /dev/cpu is only available on x86 with certain modules (e.g. msr)
enabled.
> > Using lscpu to get processors count is more portable.
> > 
> > Signed-off-by: Mike Rapoport <rppt at linux.vnet.ibm.com>
> > ---
> > v3: simplify by using lscpu -p=cpu 
> > v2: use lspcu instead of /proc/cpuinfo as per Cornelia's
suggestion
> > 
> >  tools/virtio/ringtest/run-on-all.sh | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/virtio/ringtest/run-on-all.sh
b/tools/virtio/ringtest/run-on-all.sh
> > index 52b0f71..2e69ca8 100755
> > --- a/tools/virtio/ringtest/run-on-all.sh
> > +++ b/tools/virtio/ringtest/run-on-all.sh
> > @@ -3,10 +3,10 @@
> >  #use last CPU for host. Why not the first?
> >  #many devices tend to use cpu0 by default so
> >  #it tends to be busier
> > -HOST_AFFINITY=$(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n|tail
-1)
> > +HOST_AFFINITY=$(lscpu -p=cpu | tail -1)
> > 
> >  #run command on all cpus
> > -for cpu in $(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n);
> > +for cpu in $(seq 0 $HOST_AFFINITY)
> >  do
> >  	#Don't run guest and host on same CPU
> >  	#It actually works ok if using signalling
> > -- 
> > 1.9.1
> > 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

It's queued in my tree and will be merged shortly.
Thanks!

On Mon, Jun 06, 2016 at 09:55:59AM +0300, Mike Rapoport
wrote:
> Ping?
> 
> On Tue, May 24, 2016 at 03:41:33PM +0300, Mike Rapoport wrote:
> > Michael,
> > 
> > Any updates on this?
> > 
> > On Wed, May 04, 2016 at 01:15:50PM +0300, Mike Rapoport wrote:
> > > /dev/cpu is only available on x86 with certain modules (e.g. msr)
enabled.
> > > Using lscpu to get processors count is more portable.
> > > 
> > > Signed-off-by: Mike Rapoport <rppt at linux.vnet.ibm.com>
> > > ---
> > > v3: simplify by using lscpu -p=cpu 
> > > v2: use lspcu instead of /proc/cpuinfo as per Cornelia's
suggestion
> > > 
> > >  tools/virtio/ringtest/run-on-all.sh | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/tools/virtio/ringtest/run-on-all.sh
b/tools/virtio/ringtest/run-on-all.sh
> > > index 52b0f71..2e69ca8 100755
> > > --- a/tools/virtio/ringtest/run-on-all.sh
> > > +++ b/tools/virtio/ringtest/run-on-all.sh
> > > @@ -3,10 +3,10 @@
> > >  #use last CPU for host. Why not the first?
> > >  #many devices tend to use cpu0 by default so
> > >  #it tends to be busier
> > > -HOST_AFFINITY=$(cd /dev/cpu; ls|grep -v '[a-z]'|sort
-n|tail -1)
> > > +HOST_AFFINITY=$(lscpu -p=cpu | tail -1)
> > > 
> > >  #run command on all cpus
> > > -for cpu in $(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n);
> > > +for cpu in $(seq 0 $HOST_AFFINITY)
> > >  do
> > >  	#Don't run guest and host on same CPU
> > >  	#It actually works ok if using signalling
> > > -- 
> > > 1.9.1
> > > 
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe
kvm" in
> > the body of a message to majordomo at vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >