Sinclair Yeh
2016-Mar-31 14:39 UTC
[PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW_PORT macro
Hi, Does any one know when this series will be applied? Sinclair On Mon, Feb 08, 2016 at 11:41:57AM -0800, Greg KH wrote:> On Tue, Jan 19, 2016 at 01:46:05PM -0800, Sinclair Yeh wrote: > > Updated VMWARE_BALLOON_CMD to use the common VMW_PORT macro. > > Doing this rather than replacing all instances of VMWARE_BALLOON_CMD > > to minimize code change. > > > > Signed-off-by: Sinclair Yeh <syeh at vmware.com> > > Reviewed-by: Thomas Hellstrom <thellstrom at vmware.com> > > Reviewed-by: Alok N Kataria <akataria at vmware.com> > > Acked-by: Xavier Deguillard <xdeguillard at vmware.com> > > Cc: pv-drivers at vmware.com > > Cc: Xavier Deguillard <xdeguillard at vmware.com> > > Cc: linux-kernel at vger.kernel.org > > Cc: virtualization at lists.linux-foundation.org > > Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org> > > > Acked-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org> > > > -#define VMWARE_BALLOON_CMD(cmd, arg1, arg2, result) \ > > -({ \ > > - unsigned long __status, __dummy1, __dummy2, __dummy3; \ > > - __asm__ __volatile__ ("inl %%dx" : \ > > - "=a"(__status), \ > > - "=c"(__dummy1), \ > > - "=d"(__dummy2), \ > > - "=b"(result), \ > > - "=S" (__dummy3) : \ > > - "0"(VMW_BALLOON_HV_MAGIC), \ > > - "1"(VMW_BALLOON_CMD_##cmd), \ > > - "2"(VMW_BALLOON_HV_PORT), \ > > - "3"(arg1), \ > > - "4" (arg2) : \ > > - "memory"); \ > > - if (VMW_BALLOON_CMD_##cmd == VMW_BALLOON_CMD_START) \ > > - result = __dummy1; \ > > - result &= -1UL; \ > > - __status & -1UL; \ > > +#define VMWARE_BALLOON_CMD(cmd, arg1, arg2, result) \ > > +({ \ > > + unsigned long __status, __dummy1, __dummy2; \ > > + unsigned long __si, __di; \ > > + VMW_PORT(VMW_BALLOON_CMD_##cmd, arg1, arg2, 0, \ > > + VMW_BALLOON_HV_PORT, VMW_BALLOON_HV_MAGIC, \ > > + __status, result, __dummy1, __dummy2, __si, __di); \ > > + if (VMW_BALLOON_CMD_##cmd == VMW_BALLOON_CMD_START) \ > > + result = __dummy1; \ > > + result &= -1UL; \ > > + __status & -1UL; \ > > }) > > Honestly, it doesn't look anymore "readable" to me, but it's your code > to maintain, not mine... :) >
Greg KH
2016-Mar-31 16:30 UTC
[PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW_PORT macro
On Thu, Mar 31, 2016 at 07:39:53AM -0700, Sinclair Yeh wrote:> Hi, > > Does any one know when this series will be applied?No idea, it's not going through my tree, as I don't have these in my queue anymore... greg k-h
Sinclair Yeh
2016-Mar-31 17:32 UTC
[PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW_PORT macro
On Thu, Mar 31, 2016 at 09:30:37AM -0700, Greg KH wrote:> On Thu, Mar 31, 2016 at 07:39:53AM -0700, Sinclair Yeh wrote: > > Hi, > > > > Does any one know when this series will be applied? > > No idea, it's not going through my tree, as I don't have these in my > queue anymore...Ok, I'm not sure what else to do. I've already updated the series once because it didn't get picked up last December. Can anyone on the x86 list pick this up? Sinclair
Maybe Matching Threads
- [PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW_PORT macro
- [PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW_PORT macro
- [PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW_PORT macro
- [PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW_PORT macro
- [PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW_PORT macro