Linux Virtualization - Dec 2015 - [PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW_PORT macro

Hey Sinclair,

On Tue, Dec 01, 2015 at 02:18:52PM -0800, Sinclair Yeh
wrote:
> +#define VMWARE_BALLOON_CMD(cmd, data, result)			   \
> +({								   \
> +	unsigned long __status, __dummy1, __dummy2;		   \
> +	unsigned long __si = 0, __di = 0;			   \
> +	VMW_PORT(data, VMW_BALLOON_CMD_##cmd, VMW_BALLOON_HV_PORT, \
> +		 VMW_BALLOON_HV_MAGIC,				   \
> +		 __status, result, __dummy1, __dummy2, __si, __di);\
> +	if (VMW_BALLOON_CMD_##cmd == VMW_BALLOON_CMD_START)	   \
> +		result = __dummy1;				   \
> +	result &= -1UL;						   \
> +	__status & -1UL;					   \
>  })
You need to indent the '\' with tabs only, and it looks like spaces are
present here (which is also why they don't look aligned).

Other than that I'm good with this:

Acked-by: Xavier Deguillard <xdeguillard at vmware.com>

Xavier

Thanks!  Done.

On Tue, Dec 01, 2015 at 02:38:01PM -0800, Xavier Deguillard
wrote:
> Hey Sinclair,
> 
> On Tue, Dec 01, 2015 at 02:18:52PM -0800, Sinclair Yeh wrote:
> > +#define VMWARE_BALLOON_CMD(cmd, data, result)			   \
> > +({								   \
> > +	unsigned long __status, __dummy1, __dummy2;		   \
> > +	unsigned long __si = 0, __di = 0;			   \
> > +	VMW_PORT(data, VMW_BALLOON_CMD_##cmd, VMW_BALLOON_HV_PORT, \
> > +		 VMW_BALLOON_HV_MAGIC,				   \
> > +		 __status, result, __dummy1, __dummy2, __si, __di);\
> > +	if (VMW_BALLOON_CMD_##cmd == VMW_BALLOON_CMD_START)	   \
> > +		result = __dummy1;				   \
> > +	result &= -1UL;						   \
> > +	__status & -1UL;					   \
> >  })
> 
> You need to indent the '\' with tabs only, and it looks like spaces
are
> present here (which is also why they don't look aligned).
> 
> Other than that I'm good with this:
> 
> Acked-by: Xavier Deguillard <xdeguillard at vmware.com>
> 
> Xavier