Linux Virtualization - Apr 2015 - [PATCH] virtio: fix typo in vring_need_event() doc comment

Here the "other side" refers to the guest or host.

Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com>
---
 include/uapi/linux/virtio_ring.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/virtio_ring.h b/include/uapi/linux/virtio_ring.h
index a3318f3..915980a 100644
--- a/include/uapi/linux/virtio_ring.h
+++ b/include/uapi/linux/virtio_ring.h
@@ -155,7 +155,7 @@ static inline unsigned vring_size(unsigned int num, unsigned
long align)
 }
 
 /* The following is used with USED_EVENT_IDX and AVAIL_EVENT_IDX */
-/* Assuming a given event_idx value from the other size, if
+/* Assuming a given event_idx value from the other side, if
  * we have just incremented index from old to new_idx,
  * should we trigger an event? */
 static inline int vring_need_event(__u16 event_idx, __u16 new_idx, __u16 old)
-- 
2.1.0

Stefan Hajnoczi <stefanha at redhat.com> writes:
> Here the "other side" refers to the guest or host.
>
> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com>
Applied.

Thanks!
Rusty.
> ---
>  include/uapi/linux/virtio_ring.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/virtio_ring.h
b/include/uapi/linux/virtio_ring.h
> index a3318f3..915980a 100644
> --- a/include/uapi/linux/virtio_ring.h
> +++ b/include/uapi/linux/virtio_ring.h
> @@ -155,7 +155,7 @@ static inline unsigned vring_size(unsigned int num,
unsigned long align)
>  }
>  
>  /* The following is used with USED_EVENT_IDX and AVAIL_EVENT_IDX */
> -/* Assuming a given event_idx value from the other size, if
> +/* Assuming a given event_idx value from the other side, if
>   * we have just incremented index from old to new_idx,
>   * should we trigger an event? */
>  static inline int vring_need_event(__u16 event_idx, __u16 new_idx, __u16
old)
> -- 
> 2.1.0

On Sun, Apr 19, 2015 at 02:36:38PM +0930, Rusty Russell
wrote:
> Stefan Hajnoczi <stefanha at redhat.com> writes:
> > Here the "other side" refers to the guest or host.
> >
> > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com>
> 
> Applied.
> 
> Thanks!
> Rusty.
Just to make sure, are you applying this for 4.1?
> > ---
> >  include/uapi/linux/virtio_ring.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/uapi/linux/virtio_ring.h
b/include/uapi/linux/virtio_ring.h
> > index a3318f3..915980a 100644
> > --- a/include/uapi/linux/virtio_ring.h
> > +++ b/include/uapi/linux/virtio_ring.h
> > @@ -155,7 +155,7 @@ static inline unsigned vring_size(unsigned int
num, unsigned long align)
> >  }
> >  
> >  /* The following is used with USED_EVENT_IDX and AVAIL_EVENT_IDX */
> > -/* Assuming a given event_idx value from the other size, if
> > +/* Assuming a given event_idx value from the other side, if
> >   * we have just incremented index from old to new_idx,
> >   * should we trigger an event? */
> >  static inline int vring_need_event(__u16 event_idx, __u16 new_idx,
__u16 old)
> > -- 
> > 2.1.0