Theodore Ts'o
2014-Apr-01 02:27 UTC
[PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor
On Mon, Mar 31, 2014 at 02:22:50PM +1030, Rusty Russell wrote:> > It's head of my virtio-next tree.Hey Rusty, While we have your attention --- what's your opinion about adding TRIM support to virtio-blk. I understand that you're starting an OASIS standardization process for virtio --- what does that mean vis-a-vis a patch to plumb discard support through virtio-blk? Thanks! - Ted
Stefan Hajnoczi
2014-Apr-01 10:49 UTC
[PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor
On Tue, Apr 1, 2014 at 4:27 AM, Theodore Ts'o <tytso at mit.edu> wrote:> On Mon, Mar 31, 2014 at 02:22:50PM +1030, Rusty Russell wrote: >> >> It's head of my virtio-next tree. > > Hey Rusty, > > While we have your attention --- what's your opinion about adding TRIM > support to virtio-blk. I understand that you're starting an OASIS > standardization process for virtio --- what does that mean vis-a-vis a > patch to plumb discard support through virtio-blk?virtio-scsi already supports discard. But maybe you cannot switch away from virtio-blk? If you need to add discard to virtio-blk then it could be added to the standard. The standards text is kept in a svn repository here: https://tools.oasis-open.org/version-control/browse/wsvn/virtio/ Stefan
Rusty Russell
2014-Apr-02 07:36 UTC
[PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor
Stefan Hajnoczi <stefanha at gmail.com> writes:> On Tue, Apr 1, 2014 at 4:27 AM, Theodore Ts'o <tytso at mit.edu> wrote: >> On Mon, Mar 31, 2014 at 02:22:50PM +1030, Rusty Russell wrote: >>> >>> It's head of my virtio-next tree. >> >> Hey Rusty, >> >> While we have your attention --- what's your opinion about adding TRIM >> support to virtio-blk. I understand that you're starting an OASIS >> standardization process for virtio --- what does that mean vis-a-vis a >> patch to plumb discard support through virtio-blk? > > virtio-scsi already supports discard. But maybe you cannot switch > away from virtio-blk? > > If you need to add discard to virtio-blk then it could be added to the > standard. The standards text is kept in a svn repository here: > https://tools.oasis-open.org/version-control/browse/wsvn/virtio/It would be trivial to add, and I wouldn't be completely opposed, but we generally point to virtio-scsi when people want actual features. Cheers, Rusty.
Apparently Analagous Threads
- [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor
- [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor
- [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor
- [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor
- [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor