Eric Dumazet
2014-Jan-08 18:26 UTC
[PATCH net-next v2 1/4] net: allow > 0 order atomic page alloc in skb_page_frag_refill
On Wed, 2014-01-08 at 20:08 +0200, Michael S. Tsirkin wrote:> Eric said we also need a patch to add __GFP_NORETRY, right? > Probably before this one in series.Nope, this __GFP_NORETRY has nothing to do with this. I am not yet convinced we want it. This needs mm guys advice, as its a tradeoff for mm layer more than networking...
Michael S. Tsirkin
2014-Jan-08 19:18 UTC
[PATCH net-next v2 1/4] net: allow > 0 order atomic page alloc in skb_page_frag_refill
On Wed, Jan 08, 2014 at 10:26:03AM -0800, Eric Dumazet wrote:> On Wed, 2014-01-08 at 20:08 +0200, Michael S. Tsirkin wrote: > > > Eric said we also need a patch to add __GFP_NORETRY, right? > > Probably before this one in series. > > Nope, this __GFP_NORETRY has nothing to do with this. > > I am not yet convinced we want it. > > This needs mm guys advice, as its a tradeoff for mm layer more than > networking...Well maybe Cc linux-mm then?
Eric Dumazet
2014-Jan-08 19:46 UTC
[PATCH net-next v2 1/4] net: allow > 0 order atomic page alloc in skb_page_frag_refill
On Wed, 2014-01-08 at 21:18 +0200, Michael S. Tsirkin wrote:> On Wed, Jan 08, 2014 at 10:26:03AM -0800, Eric Dumazet wrote: > > On Wed, 2014-01-08 at 20:08 +0200, Michael S. Tsirkin wrote: > > > > > Eric said we also need a patch to add __GFP_NORETRY, right? > > > Probably before this one in series. > > > > Nope, this __GFP_NORETRY has nothing to do with this. > > > > I am not yet convinced we want it. > > > > This needs mm guys advice, as its a tradeoff for mm layer more than > > networking... > > Well maybe Cc linux-mm then?Well, I do not care of people mlocking the memory and complaining that compaction does not work. If these people care, they should contact mm guys, eventually. Really this is an issue that has nothing to do with this patch set.
Possibly Parallel Threads
- [PATCH net-next v2 1/4] net: allow > 0 order atomic page alloc in skb_page_frag_refill
- [PATCH net-next v2 1/4] net: allow > 0 order atomic page alloc in skb_page_frag_refill
- [PATCH net-next v2 1/4] net: allow > 0 order atomic page alloc in skb_page_frag_refill
- [PATCH net-next v2 1/4] net: allow > 0 order atomic page alloc in skb_page_frag_refill
- [PATCH net-next v2 1/4] net: allow > 0 order atomic page alloc in skb_page_frag_refill