Linux Virtualization - Jun 2013 - [PATCH] vhost-scsi: return -ENOENT when no matching tcm_vhost_tpg found

ioctl for VHOST_SCSI_SET_ENDPOINT report file exist errori, when I forget
to set it correctly in configfs, make user confused. Actually it fail
to find a matching one, so change the error value.

Signed-off-by: Wenchao Xia <wenchaolinux at gmail.com>
---
 drivers/vhost/scsi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 7014202..6325b1d 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -1219,7 +1219,7 @@ static int vhost_scsi_set_endpoint(
 		}
 		ret = 0;
 	} else {
-		ret = -EEXIST;
+		ret = -ENOENT;
 	}
 
 	/*
-- 
1.7.1

On Tue, May 28, 2013 at 04:54:44PM +0800, Wenchao Xia
wrote:
> ioctl for VHOST_SCSI_SET_ENDPOINT report file exist errori, when I forget
> to set it correctly in configfs, make user confused. Actually it fail
> to find a matching one, so change the error value.
> 
> Signed-off-by: Wenchao Xia <wenchaolinux at gmail.com>
Acked-by: Asias He <asias at redhat.com>

BTW, It would be nice to print more informative info in qemu when wwpn
is not available as well.
> ---
>  drivers/vhost/scsi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
> index 7014202..6325b1d 100644
> --- a/drivers/vhost/scsi.c
> +++ b/drivers/vhost/scsi.c
> @@ -1219,7 +1219,7 @@ static int vhost_scsi_set_endpoint(
>  		}
>  		ret = 0;
>  	} else {
> -		ret = -EEXIST;
> +		ret = -ENOENT;
>  	}
>  
>  	/*
> -- 
> 1.7.1
> 
-- 
Asias

cc to Greg for 3.9.
> On Tue, May 28, 2013 at 04:54:44PM +0800, Wenchao Xia wrote:
>> ioctl for VHOST_SCSI_SET_ENDPOINT report file exist errori, when I
forget
>> to set it correctly in configfs, make user confused. Actually it fail
>> to find a matching one, so change the error value.
>>
>> Signed-off-by: Wenchao Xia <wenchaolinux at gmail.com>
>
> Acked-by: Asias He <asias at redhat.com>
>
> BTW, It would be nice to print more informative info in qemu when wwpn
> is not available as well.
>
>> ---
>>   drivers/vhost/scsi.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
>> index 7014202..6325b1d 100644
>> --- a/drivers/vhost/scsi.c
>> +++ b/drivers/vhost/scsi.c
>> @@ -1219,7 +1219,7 @@ static int vhost_scsi_set_endpoint(
>>   		}
>>   		ret = 0;
>>   	} else {
>> -		ret = -EEXIST;
>> +		ret = -ENOENT;
>>   	}
>>
>>   	/*
>> --
>> 1.7.1
>>
>