Asias He
2013-Apr-27 03:42 UTC
[PATCH] tcm_vhost: Add vhost_scsi as an alias for tcm_vhost
Signed-off-by: Asias He <asias at redhat.com>
---
drivers/vhost/tcm_vhost.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c
index 1677238..bddc39a 100644
--- a/drivers/vhost/tcm_vhost.c
+++ b/drivers/vhost/tcm_vhost.c
@@ -1928,5 +1928,6 @@ static void tcm_vhost_exit(void)
MODULE_DESCRIPTION("TCM_VHOST series fabric driver");
MODULE_LICENSE("GPL");
+MODULE_ALIAS("vhost_scsi");
module_init(tcm_vhost_init);
module_exit(tcm_vhost_exit);
--
1.8.1.4
Michael S. Tsirkin
2013-Apr-28 12:43 UTC
[PATCH] tcm_vhost: Add vhost_scsi as an alias for tcm_vhost
On Sat, Apr 27, 2013 at 11:42:09AM +0800, Asias He wrote:> Signed-off-by: Asias He <asias at redhat.com>Makes sense. Acked-by: Michael S. Tsirkin <mst at redhat.com> In fact, how about we turn this around, and rename tcm_vhost.c to scsi.c and module to vhost_scsi, make tcm_vhost an alias?> --- > drivers/vhost/tcm_vhost.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c > index 1677238..bddc39a 100644 > --- a/drivers/vhost/tcm_vhost.c > +++ b/drivers/vhost/tcm_vhost.c > @@ -1928,5 +1928,6 @@ static void tcm_vhost_exit(void) > > MODULE_DESCRIPTION("TCM_VHOST series fabric driver"); > MODULE_LICENSE("GPL"); > +MODULE_ALIAS("vhost_scsi"); > module_init(tcm_vhost_init); > module_exit(tcm_vhost_exit); > -- > 1.8.1.4
Michael S. Tsirkin
2013-May-01 06:42 UTC
[PATCH] tcm_vhost: Add vhost_scsi as an alias for tcm_vhost
On Sat, Apr 27, 2013 at 11:42:09AM +0800, Asias He wrote:> Signed-off-by: Asias He <asias at redhat.com>Nicholas, thoughts? How about we move tcm_vhost.c to scsi.c call module vhost_scsi and add tcm_vhost as an alias? If not - want this alias in?> --- > drivers/vhost/tcm_vhost.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c > index 1677238..bddc39a 100644 > --- a/drivers/vhost/tcm_vhost.c > +++ b/drivers/vhost/tcm_vhost.c > @@ -1928,5 +1928,6 @@ static void tcm_vhost_exit(void) > > MODULE_DESCRIPTION("TCM_VHOST series fabric driver"); > MODULE_LICENSE("GPL"); > +MODULE_ALIAS("vhost_scsi"); > module_init(tcm_vhost_init); > module_exit(tcm_vhost_exit); > -- > 1.8.1.4
Nicholas A. Bellinger
2013-May-01 16:07 UTC
[PATCH] tcm_vhost: Add vhost_scsi as an alias for tcm_vhost
On Wed, 2013-05-01 at 09:42 +0300, Michael S. Tsirkin wrote:> On Sat, Apr 27, 2013 at 11:42:09AM +0800, Asias He wrote: > > Signed-off-by: Asias He <asias at redhat.com> > > > Nicholas, thoughts? > How about we move tcm_vhost.c to scsi.c > call module vhost_scsi and add tcm_vhost as an alias? > If not - want this alias in? >No objection on my side.. Shall I rebase a branch on top of your vhost-net-next + perform the rename, or do you want to send this via net-next..? --nab> > --- > > drivers/vhost/tcm_vhost.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c > > index 1677238..bddc39a 100644 > > --- a/drivers/vhost/tcm_vhost.c > > +++ b/drivers/vhost/tcm_vhost.c > > @@ -1928,5 +1928,6 @@ static void tcm_vhost_exit(void) > > > > MODULE_DESCRIPTION("TCM_VHOST series fabric driver"); > > MODULE_LICENSE("GPL"); > > +MODULE_ALIAS("vhost_scsi"); > > module_init(tcm_vhost_init); > > module_exit(tcm_vhost_exit); > > -- > > 1.8.1.4 > -- > To unsubscribe from this list: send the line "unsubscribe target-devel" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Asias He
2013-May-02 04:27 UTC
[PATCH] tcm_vhost: Add vhost_scsi as an alias for tcm_vhost
On Wed, May 01, 2013 at 09:42:22AM +0300, Michael S. Tsirkin wrote:> On Sat, Apr 27, 2013 at 11:42:09AM +0800, Asias He wrote: > > Signed-off-by: Asias He <asias at redhat.com> > > > Nicholas, thoughts? > How about we move tcm_vhost.c to scsi.c > call module vhost_scsi and add tcm_vhost as an alias?This is even better ;-)> If not - want this alias in? > > > --- > > drivers/vhost/tcm_vhost.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c > > index 1677238..bddc39a 100644 > > --- a/drivers/vhost/tcm_vhost.c > > +++ b/drivers/vhost/tcm_vhost.c > > @@ -1928,5 +1928,6 @@ static void tcm_vhost_exit(void) > > > > MODULE_DESCRIPTION("TCM_VHOST series fabric driver"); > > MODULE_LICENSE("GPL"); > > +MODULE_ALIAS("vhost_scsi"); > > module_init(tcm_vhost_init); > > module_exit(tcm_vhost_exit); > > -- > > 1.8.1.4-- Asias