Ryota Ozaki
2013-Jan-26 08:54 UTC
[PATCH][trivial] virtio-mmio: fix wrong comment about register offset
The register offset of InterruptACK is 0x064, not 0x060. Fix it. Signed-off-by: Ryota Ozaki <ozaki.ryota at gmail.com> CC: Pawel Moll <pawel.moll at arm.com> CC: Rusty Russell <rusty at rustcorp.com.au> CC: Jiri Kosina <trivial at kernel.org> --- drivers/virtio/virtio_mmio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index 31f966f..833e6db 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -75,7 +75,7 @@ * * 0x050 W QueueNotify Queue notifier * 0x060 R InterruptStatus Interrupt status register - * 0x060 W InterruptACK Interrupt acknowledge register + * 0x064 W InterruptACK Interrupt acknowledge register * 0x070 RW Status Device status register * * 0x100+ RW Device-specific configuration space -- 1.7.12
Wanlong Gao
2013-Jan-28 04:03 UTC
[PATCH][trivial] virtio-mmio: fix wrong comment about register offset
On 01/26/2013 04:54 PM, Ryota Ozaki wrote:> The register offset of InterruptACK is 0x064, not 0x060. > Fix it. > > Signed-off-by: Ryota Ozaki <ozaki.ryota at gmail.com> > CC: Pawel Moll <pawel.moll at arm.com> > CC: Rusty Russell <rusty at rustcorp.com.au> > CC: Jiri Kosina <trivial at kernel.org>Reviewed-by: Wanlong Gao <gaowanlong at cn.fujitsu.com>> --- > drivers/virtio/virtio_mmio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c > index 31f966f..833e6db 100644 > --- a/drivers/virtio/virtio_mmio.c > +++ b/drivers/virtio/virtio_mmio.c > @@ -75,7 +75,7 @@ > * > * 0x050 W QueueNotify Queue notifier > * 0x060 R InterruptStatus Interrupt status register > - * 0x060 W InterruptACK Interrupt acknowledge register > + * 0x064 W InterruptACK Interrupt acknowledge register > * 0x070 RW Status Device status register > * > * 0x100+ RW Device-specific configuration space >
Pawel Moll
2013-Jan-28 10:05 UTC
[PATCH][trivial] virtio-mmio: fix wrong comment about register offset
On Sat, 2013-01-26 at 08:54 +0000, Ryota Ozaki wrote:> The register offset of InterruptACK is 0x064, not 0x060. > Fix it. > > Signed-off-by: Ryota Ozaki <ozaki.ryota at gmail.com> > CC: Pawel Moll <pawel.moll at arm.com> > CC: Rusty Russell <rusty at rustcorp.com.au> > CC: Jiri Kosina <trivial at kernel.org> > --- > drivers/virtio/virtio_mmio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c > index 31f966f..833e6db 100644 > --- a/drivers/virtio/virtio_mmio.c > +++ b/drivers/virtio/virtio_mmio.c > @@ -75,7 +75,7 @@ > * > * 0x050 W QueueNotify Queue notifier > * 0x060 R InterruptStatus Interrupt status register > - * 0x060 W InterruptACK Interrupt acknowledge register > + * 0x064 W InterruptACK Interrupt acknowledge register > * 0x070 RW Status Device status register > * > * 0x100+ RW Device-specific configuration spaceAcked-by: Pawel Moll <pawel.moll at arm.com> Thanks! Pawel
Rusty Russell
2013-Feb-04 00:05 UTC
[PATCH][trivial] virtio-mmio: fix wrong comment about register offset
Pawel Moll <pawel.moll at arm.com> writes:> On Sat, 2013-01-26 at 08:54 +0000, Ryota Ozaki wrote: >> The register offset of InterruptACK is 0x064, not 0x060. >> Fix it. >> >> Signed-off-by: Ryota Ozaki <ozaki.ryota at gmail.com> >> CC: Pawel Moll <pawel.moll at arm.com> >> CC: Rusty Russell <rusty at rustcorp.com.au> >> CC: Jiri Kosina <trivial at kernel.org> >> --- >> drivers/virtio/virtio_mmio.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c >> index 31f966f..833e6db 100644 >> --- a/drivers/virtio/virtio_mmio.c >> +++ b/drivers/virtio/virtio_mmio.c >> @@ -75,7 +75,7 @@ >> * >> * 0x050 W QueueNotify Queue notifier >> * 0x060 R InterruptStatus Interrupt status register >> - * 0x060 W InterruptACK Interrupt acknowledge register >> + * 0x064 W InterruptACK Interrupt acknowledge register >> * 0x070 RW Status Device status register >> * >> * 0x100+ RW Device-specific configuration space > > Acked-by: Pawel Moll <pawel.moll at arm.com> > > Thanks! > > PawelApplied. Thanks, Rusty.