Lee Jones
2012-Nov-03 22:02 UTC
[PATCH 6/9] virtio_mmio: Cast &resources[1].start to ‘unsigned int *’ to rid compiler warning
drivers/virtio/virtio_mmio.c: In function ?vm_cmdline_set?: drivers/virtio/virtio_mmio.c:535:4: warning: format ?%u? expects argument of type ?unsigned int *?, but argument 4 has type ?resource_size_t *? [-Wformat] Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: virtualization at lists.linux-foundation.org Signed-off-by: Lee Jones <lee.jones at linaro.org> --- drivers/virtio/virtio_mmio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index 6b1b7e1..077e9ca 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -531,7 +531,7 @@ static int vm_cmdline_set(const char *device, resources[0].end = memparse(device, &str) - 1; processed = sscanf(str, "@%lli:%u%n:%d%n", - &base, &resources[1].start, &consumed, + &base, (unsigned int *)&resources[1].start, &consumed, &vm_cmdline_id, &consumed); if (processed < 2 || processed > 3 || str[consumed]) -- 1.7.9.5
Rusty Russell
2012-Nov-05 02:38 UTC
[PATCH 6/9] virtio_mmio: Cast &resources[1].start to ‘unsigned int *’ to rid compiler warning
Lee Jones <lee.jones at linaro.org> writes:> drivers/virtio/virtio_mmio.c: In function ?vm_cmdline_set?: > drivers/virtio/virtio_mmio.c:535:4: warning: format ?%u? expects argument of type ?unsigned int *?, but argument 4 has type ?resource_size_t *? [-Wformat] > > Cc: Rusty Russell <rusty at rustcorp.com.au> > Cc: virtualization at lists.linux-foundation.org > Signed-off-by: Lee Jones <lee.jones at linaro.org> > --- > drivers/virtio/virtio_mmio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c > index 6b1b7e1..077e9ca 100644 > --- a/drivers/virtio/virtio_mmio.c > +++ b/drivers/virtio/virtio_mmio.c > @@ -531,7 +531,7 @@ static int vm_cmdline_set(const char *device, > resources[0].end = memparse(device, &str) - 1; > > processed = sscanf(str, "@%lli:%u%n:%d%n", > - &base, &resources[1].start, &consumed, > + &base, (unsigned int *)&resources[1].start, &consumed, > &vm_cmdline_id, &consumed);This suppresses a valid warning, leaving our code no less wrong than before. But now it's silently wrong! Do you want to try again? Cheers, Rusty.
Maybe Matching Threads
- [PATCH 6/9] virtio_mmio: Cast &resources[1].start to ‘unsigned int *’ to rid compiler warning
- [PATCH 2/2] virtio-mmio: Reject invalid IRQ 0 command line argument
- [PATCH 2/2] virtio-mmio: Reject invalid IRQ 0 command line argument
- [PATCH] virtio-mmio: Devices parameter parsing
- [PATCH] virtio-mmio: Devices parameter parsing