strlen() doesn't count the NUL terminator. I missed this one in the patches I sent yesterday. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c index 29850cb..ea72198 100644 --- a/drivers/vhost/tcm_vhost.c +++ b/drivers/vhost/tcm_vhost.c @@ -1424,7 +1424,7 @@ static struct se_wwn *tcm_vhost_make_tport( return ERR_PTR(-EINVAL); check_len: - if (strlen(name) > TCM_VHOST_NAMELEN) { + if (strlen(name) >= TCM_VHOST_NAMELEN) { pr_err("Emulated %s Address: %s, exceeds" " max: %d\n", name, tcm_vhost_dump_proto_id(tport), TCM_VHOST_NAMELEN);
Nicholas A. Bellinger
2012-Jul-14 22:21 UTC
[patch -next] tcm_vhost: another strlen() off by one
On Fri, 2012-07-13 at 13:45 +0300, Dan Carpenter wrote:> strlen() doesn't count the NUL terminator. I missed this one in the > patches I sent yesterday. > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > > diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c > index 29850cb..ea72198 100644 > --- a/drivers/vhost/tcm_vhost.c > +++ b/drivers/vhost/tcm_vhost.c > @@ -1424,7 +1424,7 @@ static struct se_wwn *tcm_vhost_make_tport( > return ERR_PTR(-EINVAL); > > check_len: > - if (strlen(name) > TCM_VHOST_NAMELEN) { > + if (strlen(name) >= TCM_VHOST_NAMELEN) { > pr_err("Emulated %s Address: %s, exceeds" > " max: %d\n", name, tcm_vhost_dump_proto_id(tport), > TCM_VHOST_NAMELEN);Applied + squashed into the initial merge commit in for-next-merge. Thanks DanC! --nab
Reasonably Related Threads
- [patch -next] tcm_vhost: another strlen() off by one
- [patch 2/3 -next] tcm_vhost: strlen() doesn't count the terminator
- [patch 2/3 -next] tcm_vhost: strlen() doesn't count the terminator
- [RFC-v5] tcm_vhost: Initial merge for vhost level target fabric driver
- [RFC-v5] tcm_vhost: Initial merge for vhost level target fabric driver