Dan Carpenter
2012-Jul-12 14:48 UTC
[patch 3/3 -next] tcm_vhost: call kfree() on an error path
There is a memory leak here.
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c
index 57d39c5..29850cb 100644
--- a/drivers/vhost/tcm_vhost.c
+++ b/drivers/vhost/tcm_vhost.c
@@ -1420,6 +1420,7 @@ static struct se_wwn *tcm_vhost_make_tport(
pr_err("Unable to locate prefix for emulated Target Port:"
" %s\n", name);
+ kfree(tport);
return ERR_PTR(-EINVAL);
check_len:
Nicholas A. Bellinger
2012-Jul-12 21:49 UTC
[patch 3/3 -next] tcm_vhost: call kfree() on an error path
On Thu, 2012-07-12 at 17:48 +0300, Dan Carpenter wrote:> There is a memory leak here. > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > > diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c > index 57d39c5..29850cb 100644 > --- a/drivers/vhost/tcm_vhost.c > +++ b/drivers/vhost/tcm_vhost.c > @@ -1420,6 +1420,7 @@ static struct se_wwn *tcm_vhost_make_tport( > > pr_err("Unable to locate prefix for emulated Target Port:" > " %s\n", name); > + kfree(tport); > return ERR_PTR(-EINVAL); > > check_len:Applied to for-next-merge, and folding the series into the initial merge commit now.. Thank you! --nab