Dan Carpenter
2012-Jul-12 14:47 UTC
[patch 1/3 -next] tcm_vhost: unlock on error in tcm_vhost_drop_nexus()
We need to unlock here before returning.
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c
index da0b8ac..d217bed 100644
--- a/drivers/vhost/tcm_vhost.c
+++ b/drivers/vhost/tcm_vhost.c
@@ -1189,6 +1189,7 @@ static int tcm_vhost_drop_nexus(
}
if (atomic_read(&tpg->tv_tpg_vhost_count)) {
+ mutex_unlock(&tpg->tv_tpg_mutex);
pr_err("Unable to remove TCM_vHost I_T Nexus with"
" active TPG vhost count: %d\n",
atomic_read(&tpg->tv_tpg_vhost_count));
Nicholas A. Bellinger
2012-Jul-12 21:47 UTC
[patch 1/3 -next] tcm_vhost: unlock on error in tcm_vhost_drop_nexus()
On Thu, 2012-07-12 at 17:47 +0300, Dan Carpenter wrote:> We need to unlock here before returning. > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > > diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c > index da0b8ac..d217bed 100644 > --- a/drivers/vhost/tcm_vhost.c > +++ b/drivers/vhost/tcm_vhost.c > @@ -1189,6 +1189,7 @@ static int tcm_vhost_drop_nexus( > } > > if (atomic_read(&tpg->tv_tpg_vhost_count)) { > + mutex_unlock(&tpg->tv_tpg_mutex); > pr_err("Unable to remove TCM_vHost I_T Nexus with" > " active TPG vhost count: %d\n", > atomic_read(&tpg->tv_tpg_vhost_count));Applied. Thanks Dan!