H Hartley Sweeten
2011-May-04 18:44 UTC
[PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig
On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:> > The vmbus driver dependes on ACPI and PCI subsystems. Change > Kconfig to reflect this. > > Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> > Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> > --- > drivers/staging/hv/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig > index 76f0756..5e0c9f6 100644 > --- a/drivers/staging/hv/Kconfig > +++ b/drivers/staging/hv/Kconfig > @@ -1,6 +1,6 @@ > config HYPERV > tristate "Microsoft Hyper-V client drivers" > - depends on X86 && m > + depends on X86 && ACPI && PCI && m > default n > help > Select this option to run Linux as a Hyper-V client operatingACPI itself depends on PCI. It also depends on IA64 || X86. Will the vmbus driver work with IA64? If so the depends on could just be: depends on ACPI && m Also, default n is redudant since n is the default anyway. Regards, Hartley
KY Srinivasan
2011-May-04 18:48 UTC
[PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig
> -----Original Message----- > From: H Hartley Sweeten [mailto:hartleys at visionengravers.com] > Sent: Wednesday, May 04, 2011 2:44 PM > To: KY Srinivasan; gregkh at suse.de; linux-kernel at vger.kernel.org; > devel at linuxdriverproject.org; virtualization at lists.osdl.org > Cc: Haiyang Zhang > Subject: RE: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv > Kconfig > > On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote: > > > > The vmbus driver dependes on ACPI and PCI subsystems. Change > > Kconfig to reflect this. > > > > Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> > > Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> > > --- > > drivers/staging/hv/Kconfig | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig > > index 76f0756..5e0c9f6 100644 > > --- a/drivers/staging/hv/Kconfig > > +++ b/drivers/staging/hv/Kconfig > > @@ -1,6 +1,6 @@ > > config HYPERV > > tristate "Microsoft Hyper-V client drivers" > > - depends on X86 && m > > + depends on X86 && ACPI && PCI && m > > default n > > help > > Select this option to run Linux as a Hyper-V client operating > > ACPI itself depends on PCI. It also depends on IA64 || X86. Will the > vmbus driver work with IA64? If so the depends on could just be: > > depends on ACPI && mGood point; vmbus will not work on IA64 though. So, minimally we would want X86 && ACPI. I will resend this with this change. Regards, K. Y> > Also, default n is redudant since n is the default anyway. > > Regards, > Hartley
Christoph Hellwig
2011-May-04 18:51 UTC
[PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig
On Wed, May 04, 2011 at 11:51:45AM -0700, K. Y. Srinivasan wrote:> config HYPERV > tristate "Microsoft Hyper-V client drivers" > - depends on X86 && m > + depends on X86 && ACPI && PCI && mI can't see anything preventing this driver from beeing built-in, so the "depends on m" should probably go away.
K. Y. Srinivasan
2011-May-04 18:51 UTC
[PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig
The vmbus driver dependes on ACPI and PCI subsystems. Change Kconfig to reflect this. Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> --- drivers/staging/hv/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig index 76f0756..5e0c9f6 100644 --- a/drivers/staging/hv/Kconfig +++ b/drivers/staging/hv/Kconfig @@ -1,6 +1,6 @@ config HYPERV tristate "Microsoft Hyper-V client drivers" - depends on X86 && m + depends on X86 && ACPI && PCI && m default n help Select this option to run Linux as a Hyper-V client operating -- 1.7.4.1
K. Y. Srinivasan
2011-May-04 19:19 UTC
[PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig
The vmbus driver dependes on ACPI and PCI subsystems. Change Kconfig to reflect this. Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> --- drivers/staging/hv/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig index 76f0756..d8c119c 100644 --- a/drivers/staging/hv/Kconfig +++ b/drivers/staging/hv/Kconfig @@ -1,6 +1,6 @@ config HYPERV tristate "Microsoft Hyper-V client drivers" - depends on X86 && m + depends on X86 && ACPI && m default n help Select this option to run Linux as a Hyper-V client operating -- 1.7.4.1