Linux Virtualization - Mar 2011 - [PATCH] virtio console: don't manually set or finalize VIRTIO_CONSOLE_F_MULTIPORT.

That's already been done by the virtio infrastructure before the probe
function is called.

Reported-by: alexey.kardashevskiy at au1.ibm.com
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>

diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -1680,17 +1680,12 @@ static int __devinit virtcons_probe(stru
 	portdev->config.max_nr_ports = 1;
 	if (virtio_has_feature(vdev, VIRTIO_CONSOLE_F_MULTIPORT)) {
 		multiport = true;
-		vdev->features[0] |= 1 << VIRTIO_CONSOLE_F_MULTIPORT;
-
 		vdev->config->get(vdev, offsetof(struct virtio_console_config,
 						 max_nr_ports),
 				  &portdev->config.max_nr_ports,
 				  sizeof(portdev->config.max_nr_ports));
 	}
 
-	/* Let the Host know we support multiple ports.*/
-	vdev->config->finalize_features(vdev);
-
 	err = init_vqs(portdev);
 	if (err < 0) {
 		dev_err(&vdev->dev, "Error %d initializing vqs\n", err);

On (Wed) 09 Mar 2011 [13:25:30], Rusty Russell wrote:
> That's already been done by the virtio infrastructure before the probe
> function is called.
> 
> Reported-by: alexey.kardashevskiy at au1.ibm.com
> Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Acked-by: Amit Shah <amit.shah at redhat.com>
Tested-by: Amit Shah <amit.shah at redhat.com>

		Amit