[This email is either empty or too large to be displayed at this time]
For the subject on the rest of the patches they would look like: Subject: [PATCH 2/4] Staging: hv: rename hv_utils.c to hv_util.c Note the "Staging: hv:" prefix. On Wed, Dec 08, 2010 at 03:26:10PM -0700, Ky Srinivasan wrote:> >From 453acddcf55f1e68c5baf9dc5e8f601d18de15b0 Mon Sep 17 00:00:00 2001 > From: ksrinivasan <ksrinivasan at novell.com> > Date: Wed, 8 Dec 2010 12:24:58 -0700 > > The hv_utils module will be composed of more than one file. > Rename hv_utils.c to accommodate this without changing the module name. > > > Signed-off-by: ksrinivasan <ksrinivasan at novell.com>Again, use your full name. thanks, greg k-h
>>> On 12/8/2010 at 5:34 PM, in message <20101208223400.GB6714 at suse.de>, Greg KH<gregkh at suse.de> wrote:> For the subject on the rest of the patches they would look like: > Subject: [PATCH 2/4] Staging: hv: rename hv_utils.c to hv_util.c > > Note the "Staging: hv:" prefix. > > On Wed, Dec 08, 2010 at 03:26:10PM -0700, Ky Srinivasan wrote: >> >From 453acddcf55f1e68c5baf9dc5e8f601d18de15b0 Mon Sep 17 00:00:00 2001 >> From: ksrinivasan <ksrinivasan at novell.com> >> Date: Wed, 8 Dec 2010 12:24:58 -0700 >> >> The hv_utils module will be composed of more than one file. >> Rename hv_utils.c to accommodate this without changing the module name. >> >> >> Signed-off-by: ksrinivasan <ksrinivasan at novell.com> > > Again, use your full name.I will resend the patch. Thanks, K. Y> > thanks, > > greg k-h > _______________________________________________ > Virtualization mailing list > Virtualization at lists.linux-foundation.org > https://lists.linux-foundation.org/mailman/listinfo/virtualization
You must be kidding. The same in hv_kvp_onchannelcallback() and probably anywhere else. On Wed, Dec 08, 2010 at 03:26:10PM -0700, Ky Srinivasan (ksrinivasan at novell.com) wrote:> +static void shutdown_onchannelcallback(void *context) > +{ > + struct vmbus_channel *channel = context; > + u8 *buf; > + u32 buflen, recvlen; > + u64 requestid; > + u8 execute_shutdown = false; > + > + struct shutdown_msg_data *shutdown_msg; > + > + struct icmsg_hdr *icmsghdrp; > + struct icmsg_negotiate *negop = NULL; > + > + buflen = PAGE_SIZE; > + buf = kmalloc(buflen, GFP_ATOMIC); > + > + vmbus_recvpacket(channel, buf, buflen, &recvlen, &requestid); > +> +static void timesync_onchannelcallback(void *context) > +{ > + struct vmbus_channel *channel = context; > + u8 *buf; > + u32 buflen, recvlen; > + u64 requestid; > + struct icmsg_hdr *icmsghdrp; > + struct ictimesync_data *timedatap; > + > + buflen = PAGE_SIZE; > + buf = kmalloc(buflen, GFP_ATOMIC); > + > + vmbus_recvpacket(channel, buf, buflen, &recvlen, &requestid);> +static void heartbeat_onchannelcallback(void *context) > +{ > + struct vmbus_channel *channel = context; > + u8 *buf; > + u32 buflen, recvlen; > + u64 requestid; > + struct icmsg_hdr *icmsghdrp; > + struct heartbeat_msg_data *heartbeat_msg; > + > + buflen = PAGE_SIZE; > + buf = kmalloc(buflen, GFP_ATOMIC); > + > + vmbus_recvpacket(channel, buf, buflen, &recvlen, &requestid);-- Evgeniy Polyakov
>>> On 12/8/2010 at 5:55 PM, in message <20101208225524.GA11869 at ioremap.net>,Evgeniy Polyakov <zbr at ioremap.net> wrote:> You must be kidding. > The same in hv_kvp_onchannelcallback() and probably anywhere else.Hank, if it is ok with you, I will fix this issue across the board and submit that as part of this patch set. Regards, K. Y> > On Wed, Dec 08, 2010 at 03:26:10PM -0700, Ky Srinivasan > (ksrinivasan at novell.com) wrote: >> +static void shutdown_onchannelcallback(void *context) >> +{ >> + struct vmbus_channel *channel = context; >> + u8 *buf; >> + u32 buflen, recvlen; >> + u64 requestid; >> + u8 execute_shutdown = false; >> + >> + struct shutdown_msg_data *shutdown_msg; >> + >> + struct icmsg_hdr *icmsghdrp; >> + struct icmsg_negotiate *negop = NULL; >> + >> + buflen = PAGE_SIZE; >> + buf = kmalloc(buflen, GFP_ATOMIC); >> + >> + vmbus_recvpacket(channel, buf, buflen, &recvlen, &requestid); >> + > >> +static void timesync_onchannelcallback(void *context) >> +{ >> + struct vmbus_channel *channel = context; >> + u8 *buf; >> + u32 buflen, recvlen; >> + u64 requestid; >> + struct icmsg_hdr *icmsghdrp; >> + struct ictimesync_data *timedatap; >> + >> + buflen = PAGE_SIZE; >> + buf = kmalloc(buflen, GFP_ATOMIC); >> + >> + vmbus_recvpacket(channel, buf, buflen, &recvlen, &requestid); > >> +static void heartbeat_onchannelcallback(void *context) >> +{ >> + struct vmbus_channel *channel = context; >> + u8 *buf; >> + u32 buflen, recvlen; >> + u64 requestid; >> + struct icmsg_hdr *icmsghdrp; >> + struct heartbeat_msg_data *heartbeat_msg; >> + >> + buflen = PAGE_SIZE; >> + buf = kmalloc(buflen, GFP_ATOMIC); >> + >> + vmbus_recvpacket(channel, buf, buflen, &recvlen, &requestid);
> From: Evgeniy Polyakov [mailto:zbr at ioremap.net] > Sent: Wednesday, December 08, 2010 2:55 PM > To: Ky Srinivasan > Cc: devel at driverdev.osuosl.org; Virtualization at lists.osdl.org; Haiyang Zhang; > Hank Janssen; Greg KH; Stephen Hemminger > Subject: Re: [PATCH 2/4] Rename the file hv_utils.c > > You must be kidding. > The same in hv_kvp_onchannelcallback() and probably anywhere else. >I will submit the patch that will correct this like I stated in an earlier email today. The patch should be submitted by tomorrow. Thanks, Hank.