Julia Lawall
2010-Oct-26 10:25 UTC
[PATCH 3/14] drivers/vhost/vhost.c: delete double assignment
From: Julia Lawall <julia at diku.dk> Delete successive assignments to the same location. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression i; @@ *i = ...; i = ...; // </smpl> Signed-off-by: Julia Lawall <julia at diku.dk> --- drivers/vhost/vhost.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 94701ff..ed27727 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -157,7 +157,6 @@ static void vhost_vq_reset(struct vhost_dev *dev, vq->avail_idx = 0; vq->last_used_idx = 0; vq->used_flags = 0; - vq->used_flags = 0; vq->log_used = false; vq->log_addr = -1ull; vq->vhost_hlen = 0;
Michael S. Tsirkin
2010-Oct-26 11:06 UTC
[PATCH 3/14] drivers/vhost/vhost.c: delete double assignment
On Tue, Oct 26, 2010 at 12:25:32PM +0200, Julia Lawall wrote:> From: Julia Lawall <julia at diku.dk> > > Delete successive assignments to the same location. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression i; > @@ > > *i = ...; > i = ...; > // </smpl> > > Signed-off-by: Julia Lawall <julia at diku.dk>Thanks, applied.> --- > drivers/vhost/vhost.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index 94701ff..ed27727 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers/vhost/vhost.c > @@ -157,7 +157,6 @@ static void vhost_vq_reset(struct vhost_dev *dev, > vq->avail_idx = 0; > vq->last_used_idx = 0; > vq->used_flags = 0; > - vq->used_flags = 0; > vq->log_used = false; > vq->log_addr = -1ull; > vq->vhost_hlen = 0;