Unnecessary cast from void* in assignment.
Signed-off-by: matt mooney <mfm at muteddisk.com>
---
arch/x86/xen/mmu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index 42086ac..7436283 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -737,7 +737,7 @@ pgd_t *xen_get_user_pgd(pgd_t *pgd)
if (offset < pgd_index(USER_LIMIT)) {
struct page *page = virt_to_page(pgd_page);
- user_ptr = (pgd_t *)page->private;
+ user_ptr = page->private;
if (user_ptr)
user_ptr += offset;
}
--
1.7.2.1
On 09/13/2010 10:18 PM, matt mooney wrote:> Unnecessary cast from void* in assignment.Not very keen on this. The cast may not be strictly required, but it does document what's going on there. J> Signed-off-by: matt mooney <mfm at muteddisk.com> > --- > arch/x86/xen/mmu.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c > index 42086ac..7436283 100644 > --- a/arch/x86/xen/mmu.c > +++ b/arch/x86/xen/mmu.c > @@ -737,7 +737,7 @@ pgd_t *xen_get_user_pgd(pgd_t *pgd) > > if (offset < pgd_index(USER_LIMIT)) { > struct page *page = virt_to_page(pgd_page); > - user_ptr = (pgd_t *)page->private; > + user_ptr = page->private; > if (user_ptr) > user_ptr += offset; > }
On 09/13/2010 10:18 PM, matt mooney wrote:> Unnecessary cast from void* in assignment. > > Signed-off-by: matt mooney <mfm at muteddisk.com> > --- > arch/x86/xen/mmu.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c > index 42086ac..7436283 100644 > --- a/arch/x86/xen/mmu.c > +++ b/arch/x86/xen/mmu.c > @@ -737,7 +737,7 @@ pgd_t *xen_get_user_pgd(pgd_t *pgd) > > if (offset < pgd_index(USER_LIMIT)) { > struct page *page = virt_to_page(pgd_page); > - user_ptr = (pgd_t *)page->private; > + user_ptr = page->private;Um, page->private is unsigned long anyway, so this is needed either way. J